Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 3431018: Merge 68004 - 2010-09-21 Cosmin Truta <ctruta@chromium.org>... (Closed)

Created:
10 years, 3 months ago by jamesr
Modified:
9 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 68004 - 2010-09-21 Cosmin Truta <ctruta@chromium.org>; Reviewed by James Robinson. RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing https://bugs.webkit.org/show_bug.cgi?id=46120 Test a style change applied to a zoomed image. * css3/style-zoomed-image.html: Added. * css3/style-zoomed-image-expected.txt: Added. 2010-09-21 Cosmin Truta <ctruta@chromium.org>; Reviewed by James Robinson. RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing https://bugs.webkit.org/show_bug.cgi?id=46120 Avoid applying operator -> to m_imageResource when its underlying pointer is NULL. * rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Checked m_imageResource. * html/HTMLImageElement.cpp: (HTMLImageElement::createRenderer): Fixed indentation. TBR=jamesr@google.com BUG=54972 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5198 lines, -0 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +1889 lines, -0 lines 0 comments Download
A + LayoutTests/css3/style-zoomed-image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/css3/style-zoomed-image-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +3305 lines, -0 lines 0 comments Download
M WebCore/html/HTMLImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M WebCore/rendering/RenderImage.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
10 years, 3 months ago (2010-09-22 01:25:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698