Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/event_router.h

Issue 343073003: Files.app: Provide detailed change information on onDirectoryChanged event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/event_router.h
diff --git a/chrome/browser/chromeos/extensions/file_manager/event_router.h b/chrome/browser/chromeos/extensions/file_manager/event_router.h
index 51850a8da57c5aa365445067df1ad18c91550666..477bc2b89416615329bc3de23e7494186508e118 100644
--- a/chrome/browser/chromeos/extensions/file_manager/event_router.h
+++ b/chrome/browser/chromeos/extensions/file_manager/event_router.h
@@ -42,6 +42,10 @@ namespace chromeos {
class NetworkState;
}
+namespace drive {
+class FileChange;
+}
+
namespace file_manager {
// Monitors changes in disk mounts, network connection state and preferences
@@ -109,6 +113,7 @@ class EventRouter
// drive::FileSystemObserver overrides.
virtual void OnDirectoryChanged(const base::FilePath& drive_path) OVERRIDE;
+ virtual void OnFileChanged(const drive::FileChange& changed_files) OVERRIDE;
virtual void OnDriveSyncError(drive::file_system::DriveSyncErrorType type,
const base::FilePath& drive_path) OVERRIDE;
@@ -146,18 +151,22 @@ class EventRouter
void OnFileManagerPrefsChanged();
// Process file watch notifications.
- void HandleFileWatchNotification(const base::FilePath& path,
+ void HandleFileWatchNotification(const drive::FileChange* list,
+ const base::FilePath& path,
bool got_error);
// Sends directory change event.
void DispatchDirectoryChangeEvent(
const base::FilePath& path,
- bool error,
+ const drive::FileChange* list,
+ bool got_error,
const std::vector<std::string>& extension_ids);
// Sends directory change event, after converting the file definition to entry
// definition.
void DispatchDirectoryChangeEventWithEntryDefinition(
+ const linked_ptr<drive::FileChange> list,
+ const std::string* extension_id,
bool watcher_error,
const EntryDefinition& entry_definition);

Powered by Google App Engine
This is Rietveld 408576698