chrome/browser/chromeos/drive/file_system/operation_test_base.cc - Issue 343073003: Files.app: Provide detailed change information on onDirectoryChanged event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system/operation_test_base.cc

Issue 343073003: Files.app: Provide detailed change information on onDirectoryChanged event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed the comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/drive/file_change.cc ('K') | « chrome/browser/chromeos/drive/file_system/operation_test_base.h ('k') | chrome/browser/chromeos/drive/file_system/remove_operation.h » ('j') | chrome/browser/chromeos/extensions/file_manager/event_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system/operation_test_base.cc

diff --git a/chrome/browser/chromeos/drive/file_system/operation_test_base.cc b/chrome/browser/chromeos/drive/file_system/operation_test_base.cc

index 6640bca926c76e456c65b64bb8cb4527f001e2ab..bacd519f9526f85410c29e4b999a1424191fd136 100644

--- a/chrome/browser/chromeos/drive/file_system/operation_test_base.cc

+++ b/chrome/browser/chromeos/drive/file_system/operation_test_base.cc

@@ -9,6 +9,7 @@

#include "chrome/browser/chromeos/drive/change_list_loader.h"

#include "chrome/browser/chromeos/drive/fake_free_disk_space_getter.h"

#include "chrome/browser/chromeos/drive/file_cache.h"

+#include "chrome/browser/chromeos/drive/file_change.h"

#include "chrome/browser/chromeos/drive/file_system/operation_observer.h"

#include "chrome/browser/chromeos/drive/job_scheduler.h"

#include "chrome/browser/chromeos/drive/resource_metadata.h"

@@ -28,9 +29,9 @@ OperationTestBase::LoggingObserver::LoggingObserver() {

OperationTestBase::LoggingObserver::~LoggingObserver() {

}

-void OperationTestBase::LoggingObserver::OnDirectoryChangedByOperation(

- const base::FilePath& path) {

- changed_paths_.insert(path);

+void OperationTestBase::LoggingObserver::OnFileChangedByOperation(

+ const FileChange& changed_files) {

+ changed_files_.Apply(changed_files);

}

void OperationTestBase::LoggingObserver::OnEntryUpdatedByOperation(