chrome/browser/chromeos/drive/file_system/operation_observer.h - Issue 343073003: Files.app: Provide detailed change information on onDirectoryChanged event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system/operation_observer.h

Issue 343073003: Files.app: Provide detailed change information on onDirectoryChanged event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed the comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/drive/file_change.cc ('K') | « chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc ('k') | chrome/browser/chromeos/drive/file_system/operation_test_base.h » ('j') | chrome/browser/chromeos/extensions/file_manager/event_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system/operation_observer.h

diff --git a/chrome/browser/chromeos/drive/file_system/operation_observer.h b/chrome/browser/chromeos/drive/file_system/operation_observer.h

index 436c53f01e8e7615ed8d8ef1efa65a445689e603..8fd8a1c4070117c0d578f97fc1641eb08e2a8254 100644

--- a/chrome/browser/chromeos/drive/file_system/operation_observer.h

+++ b/chrome/browser/chromeos/drive/file_system/operation_observer.h

@@ -10,6 +10,8 @@ class FilePath;

}

namespace drive {

+class FileChange;

namespace file_system {

// Error type of sync client.

@@ -29,8 +31,7 @@ class OperationObserver {

// Sent when a content of a directory has been changed.

// |directory_path| is a virtual directory path representing the

// changed directory.

- virtual void OnDirectoryChangedByOperation(

- const base::FilePath& directory_path) = 0;

+ virtual void OnFileChangedByOperation(const FileChange& changed_files) = 0;

// Sent when an entry is updated and sync is needed.

virtual void OnEntryUpdatedByOperation(const std::string& local_id) {}