chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc - Issue 343073003: Files.app: Provide detailed change information on onDirectoryChanged event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc

Issue 343073003: Files.app: Provide detailed change information on onDirectoryChanged event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed the comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/drive/file_change.cc ('K') | « chrome/browser/chromeos/drive/file_system/move_operation.cc ('k') | chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc » ('j') | chrome/browser/chromeos/extensions/file_manager/event_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc

diff --git a/chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc b/chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc

index c70e24d32b0864da02ccb9b6dfcf17054141c154..727ff5533376d0ce5a1c2e96397c5eddc9bd000c 100644

--- a/chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc

+++ b/chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/chromeos/drive/file_system/move_operation.h"

+#include "chrome/browser/chromeos/drive/file_change.h"

#include "chrome/browser/chromeos/drive/file_system/operation_test_base.h"

#include "google_apis/drive/test_util.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -46,8 +47,9 @@ TEST_F(MoveOperationTest, MoveFileInSameDirectory) {

EXPECT_EQ(ResourceEntry::DIRTY, dest_entry.metadata_edit_state());

EXPECT_EQ(FILE_ERROR_NOT_FOUND, GetLocalResourceEntry(src_path, &src_entry));

- EXPECT_EQ(1U, observer()->get_changed_paths().size());

- EXPECT_TRUE(observer()->get_changed_paths().count(src_path.DirName()));

+ EXPECT_EQ(2U, observer()->get_changed_files().size());

+ EXPECT_TRUE(observer()->get_changed_files().count(src_path));

+ EXPECT_TRUE(observer()->get_changed_files().count(dest_path));

EXPECT_EQ(1U, observer()->updated_local_ids().size());

EXPECT_TRUE(observer()->updated_local_ids().count(src_entry.local_id()));

@@ -75,9 +77,9 @@ TEST_F(MoveOperationTest, MoveFileFromRootToSubDirectory) {