Issue 343053003: Remove WebMediaPlayerImpl::starting_ as it's redundant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343053003: Remove WebMediaPlayerImpl::starting_ as it's redundant. (Closed)

Created:
6 years, 6 months ago by scherkus (not reviewing)

Modified:
6 years, 6 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, wjia+watch_chromium.org, mcasas+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Remove WebMediaPlayerImpl::starting_ as it's redundant. WebMediaPlayerImpl::seeking_ essentially tracks the same state. BUG=144683 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278791

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	content/renderer/media/webmediaplayer_impl.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	content/renderer/media/webmediaplayer_impl.cc	View		4 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

scherkus (not reviewing)

The CQ bit was checked by scherkus@chromium.org

6 years, 6 months ago (2014-06-20 15:44:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/343053003/1

6 years, 6 months ago (2014-06-20 15:46:12 UTC) #4

Message was sent while issue was closed.

Change committed as 278791