Revert 278472 "DevTools: Fix for Page.captureScreenshot"

Revert 278472 "DevTools: Fix for Page.captureScreenshot"

> DevTools: Fix for Page.captureScreenshot
> 
> from https://chromiumcodereview.appspot.com/190693002/
> 
> This patch makes Page.captureScreenshot synchronize with the renderer.
> When fixed implementation hits Stable it will be possible to use Page.captureScreenshot in Telemetry instead of window.chrome.gpuBenchmarking.beginWindowSnapshotPNG and remove the latter.
> 
> BUG=242405
> 
> Review URL: https://codereview.chromium.org/311313003

TBR=vkuzkokov@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278498

[yzshen1, 2014-06-19 21:46:25]

Committed patchset #1 manually as r278498 (tree was closed).

[yzshen1, 2014-06-19 21:47:54]

I think it caused failure on
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg...

Output of the bot:
===========================================================================
CaptureScreenshotTest.CaptureScreenshot (run #1):
[ RUN      ] CaptureScreenshotTest.CaptureScreenshot
objc[11586]: Class MockCrApp is implemented in both
/Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__1_/build/src/out/Debug/Content
Shell.app/Contents/Frameworks/Content Shell
Helper.app/Contents/MacOS/../../../../../../libblink_web.dylib and
/Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__1_/build/src/out/Debug/Content
Shell.app/Contents/Frameworks/Content Shell
Helper.app/Contents/MacOS/../../../Content Shell
Framework.framework/Content Shell Framework. One of the two will be used.
Which one is undefined.
../../content/browser/devtools/renderer_overrides_handler_browsertest.cc:133:
Failure
Value of: (((color) >> 16) & 0xFF)
  Actual: 17
Expected: 0x12U
Which is: 18
../../content/browser/devtools/renderer_overrides_handler_browsertest.cc:134:
Failure
Value of: (((color) >> 8) & 0xFF)
  Actual: 51
Expected: 0x34U
Which is: 52
[  FAILED  ] CaptureScreenshotTest.CaptureScreenshot, where TypeParam =
 and GetParam() =  (996 ms)

CaptureScreenshotTest.CaptureScreenshot (run #2):
[ RUN      ] CaptureScreenshotTest.CaptureScreenshot
objc[13590]: Class MockCrApp is implemented in both
/Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__1_/build/src/out/Debug/Content
Shell.app/Contents/Frameworks/Content Shell
Helper.app/Contents/MacOS/../../../../../../libblink_web.dylib and
/Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__1_/build/src/out/Debug/Content
Shell.app/Contents/Frameworks/Content Shell
Helper.app/Contents/MacOS/../../../Content Shell
Framework.framework/Content Shell Framework. One of the two will be used.
Which one is undefined.
../../content/browser/devtools/renderer_overrides_handler_browsertest.cc:133:
Failure
Value of: (((color) >> 16) & 0xFF)
  Actual: 17
Expected: 0x12U
Which is: 18
../../content/browser/devtools/renderer_overrides_handler_browsertest.cc:134:
Failure
Value of: (((color) >> 8) & 0xFF)
  Actual: 51
Expected: 0x34U
Which is: 52
[  FAILED  ] CaptureScreenshotTest.CaptureScreenshot, where TypeParam =
 and GetParam() =  (1133 ms)

CaptureScreenshotTest.CaptureScreenshot (run #3):
[ RUN      ] CaptureScreenshotTest.CaptureScreenshot
objc[13592]: Class MockCrApp is implemented in both
/Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__1_/build/src/out/Debug/Content
Shell.app/Contents/Frameworks/Content Shell
Helper.app/Contents/MacOS/../../../../../../libblink_web.dylib and
/Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__1_/build/src/out/Debug/Content
Shell.app/Contents/Frameworks/Content Shell
Helper.app/Contents/MacOS/../../../Content Shell
Framework.framework/Content Shell Framework. One of the two will be used.
Which one is undefined.
../../content/browser/devtools/renderer_overrides_handler_browsertest.cc:133:
Failure
Value of: (((color) >> 16) & 0xFF)
  Actual: 17
Expected: 0x12U
Which is: 18
../../content/browser/devtools/renderer_overrides_handler_browsertest.cc:134:
Failure
Value of: (((color) >> 8) & 0xFF)
  Actual: 51
Expected: 0x34U
Which is: 52
[  FAILED  ] CaptureScreenshotTest.CaptureScreenshot, where TypeParam =
 and GetParam() =  (1140 ms)

CaptureScreenshotTest.CaptureScreenshot (run #4):
[ RUN      ] CaptureScreenshotTest.CaptureScreenshot
objc[13594]: Class MockCrApp is implemented in both
/Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__1_/build/src/out/Debug/Content
Shell.app/Contents/Frameworks/Content Shell
Helper.app/Contents/MacOS/../../../../../../libblink_web.dylib and
/Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__1_/build/src/out/Debug/Content
Shell.app/Contents/Frameworks/Content Shell
Helper.app/Contents/MacOS/../../../Content Shell
Framework.framework/Content Shell Framework. One of the two will be used.
Which one is undefined.
../../content/browser/devtools/renderer_overrides_handler_browsertest.cc:133:
Failure
Value of: (((color) >> 16) & 0xFF)
  Actual: 17
Expected: 0x12U
Which is: 18
../../content/browser/devtools/renderer_overrides_handler_browsertest.cc:134:
Failure
Value of: (((color) >> 8) & 0xFF)
  Actual: 51
Expected: 0x34U
Which is: 52
[  FAILED  ] CaptureScreenshotTest.CaptureScreenshot, where TypeParam =
 and GetParam() =  (1152 ms)


On Thu, Jun 19, 2014 at 2:43 PM, <yzshen@chromium.org> wrote:

> Reviewers: vkuzkokov,
>
> Description:
> Revert 278472 "DevTools: Fix for Page.captureScreenshot"
>
>  DevTools: Fix for Page.captureScreenshot
>>
>
>  from https://chromiumcodereview.appspot.com/190693002/
>>
>
>  This patch makes Page.captureScreenshot synchronize with the renderer.
>> When fixed implementation hits Stable it will be possible to use
>>
> Page.captureScreenshot in Telemetry instead of
> window.chrome.gpuBenchmarking.beginWindowSnapshotPNG and remove the
> latter.
>
>  BUG=242405
>>
>
>  Review URL: https://codereview.chromium.org/311313003
>>
>
> TBR=vkuzkokov@chromium.org
>
> Please review this at https://codereview.chromium.org/343033002/
>
> SVN Base: svn://svn.chromium.org/chrome/
>
> Affected files (+82, -209 lines):
>   M     trunk/src/content/browser/devtools/renderer_overrides_handler.h
>   M     trunk/src/content/browser/devtools/renderer_overrides_handler.cc
>   M     trunk/src/content/browser/devtools/renderer_overrides_
> handler_browsertest.cc
>   M     trunk/src/content/browser/renderer_host/render_widget_host_impl.h
>   M     trunk/src/content/browser/renderer_host/render_widget_host_impl.cc
>   M     trunk/src/content/browser/renderer_host/render_widget_
> host_view_mac.mm
>   M     trunk/src/content/common/view_messages.h
>   M     trunk/src/content/renderer/render_view_impl.h
>   M     trunk/src/content/renderer/render_view_impl.cc
>   M     trunk/src/ui/events/latency_info.h
>   M     trunk/src/ui/events/latency_info.cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.