Issue 343023002: When enabling new profile management programmatically, make sure to set the

Issue 343023002: When enabling new profile management programmatically, make sure to set the (Closed)

Created:
6 years, 6 months ago by Roger Tawa OOO till Jul 10th

Modified:
6 years, 6 months ago

Reviewers:
noms (inactive), guohui

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

When enabling new profile management programmatically, make sure to set the experiment state correctly now that its a multi-valued option. BUG=386680 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278788

Patch Set 1 #

Patch Set 2 : Use Experiment struct #

Total comments: 2

Patch Set 3 : Address review comments #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	chrome/browser/profiles/profile_window.cc	View	1 2	1 chunk	+16 lines, -1 line	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

Hi Hui, Monica, Please take a look. Thanks.

6 years, 6 months ago (2014-06-19 21:07:14 UTC) #1

guohui

lgtm https://codereview.chromium.org/343023002/diff/20001/chrome/browser/profiles/profile_window.cc File chrome/browser/profiles/profile_window.cc (right): https://codereview.chromium.org/343023002/diff/20001/chrome/browser/profiles/profile_window.cc#newcode328 chrome/browser/profiles/profile_window.cc:328: 0, nits: probably add comments to each argument ...

6 years, 6 months ago (2014-06-19 21:27:53 UTC) #2

Roger Tawa OOO till Jul 10th

Thanks Hui. https://codereview.chromium.org/343023002/diff/20001/chrome/browser/profiles/profile_window.cc File chrome/browser/profiles/profile_window.cc (right): https://codereview.chromium.org/343023002/diff/20001/chrome/browser/profiles/profile_window.cc#newcode328 chrome/browser/profiles/profile_window.cc:328: 0, On 2014/06/19 21:27:52, guohui wrote: > ...

6 years, 6 months ago (2014-06-19 22:42:46 UTC) #3

noms (inactive)

lgtm https://codereview.chromium.org/343023002/diff/40001/chrome/browser/profiles/profile_window.cc File chrome/browser/profiles/profile_window.cc (right): https://codereview.chromium.org/343023002/diff/40001/chrome/browser/profiles/profile_window.cc#newcode329 chrome/browser/profiles/profile_window.cc:329: 0, // string id for description of experiment ...

6 years, 6 months ago (2014-06-20 14:44:19 UTC) #4

Roger Tawa OOO till Jul 10th

The CQ bit was checked by rogerta@chromium.org

6 years, 6 months ago (2014-06-20 15:12:50 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/343023002/40001

6 years, 6 months ago (2014-06-20 15:14:43 UTC) #6

Message was sent while issue was closed.

Change committed as 278788

Expand Messages | Collapse Messages