Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: ui/gfx/ipc/gfx_param_traits.cc

Issue 343003003: Move IPC traits for SkBitmap, gfx_geometry into ui/gfx/ipc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix some missing includes & gfx_ipc deps Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/ipc/gfx_param_traits.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/ipc/gfx_param_traits.cc
diff --git a/content/public/common/common_param_traits.cc b/ui/gfx/ipc/gfx_param_traits.cc
similarity index 64%
copy from content/public/common/common_param_traits.cc
copy to ui/gfx/ipc/gfx_param_traits.cc
index 956801a178a2095e375097b370c42a4b6eac2e44..245211982d55cf3664e476db53e094a7a7d44756 100644
--- a/content/public/common/common_param_traits.cc
+++ b/ui/gfx/ipc/gfx_param_traits.cc
@@ -2,16 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "content/public/common/common_param_traits.h"
+#include "ui/gfx/ipc/gfx_param_traits.h"
#include <string>
-#include "content/public/common/content_constants.h"
-#include "content/public/common/page_state.h"
-#include "content/public/common/referrer.h"
-#include "content/public/common/url_utils.h"
-#include "net/base/host_port_pair.h"
-#include "net/base/ip_endpoint.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/gfx/rect.h"
#include "ui/gfx/rect_f.h"
@@ -53,130 +47,6 @@ struct SkBitmap_Data {
namespace IPC {
-void ParamTraits<GURL>::Write(Message* m, const GURL& p) {
- DCHECK(p.possibly_invalid_spec().length() <= content::GetMaxURLChars());
-
- // Beware of print-parse inconsistency which would change an invalid
- // URL into a valid one. Ideally, the message would contain this flag
- // so that the read side could make the check, but performing it here
- // avoids changing the on-the-wire representation of such a fundamental
- // type as GURL. See https://crbug.com/166486 for additional work in
- // this area.
- if (!p.is_valid()) {
- m->WriteString(std::string());
- return;
- }
-
- m->WriteString(p.possibly_invalid_spec());
- // TODO(brettw) bug 684583: Add encoding for query params.
-}
-
-bool ParamTraits<GURL>::Read(const Message* m, PickleIterator* iter, GURL* p) {
- std::string s;
- if (!m->ReadString(iter, &s) || s.length() > content::GetMaxURLChars()) {
- *p = GURL();
- return false;
- }
- *p = GURL(s);
- if (!s.empty() && !p->is_valid()) {
- *p = GURL();
- return false;
- }
- return true;
-}
-
-void ParamTraits<GURL>::Log(const GURL& p, std::string* l) {
- l->append(p.spec());
-}
-
-void ParamTraits<url::Origin>::Write(Message* m,
- const url::Origin& p) {
- m->WriteString(p.string());
-}
-
-bool ParamTraits<url::Origin>::Read(const Message* m,
- PickleIterator* iter,
- url::Origin* p) {
- std::string s;
- if (!m->ReadString(iter, &s)) {
- *p = url::Origin();
- return false;
- }
- *p = url::Origin(s);
- return true;
-}
-
-void ParamTraits<url::Origin>::Log(const url::Origin& p, std::string* l) {
- l->append(p.string());
-}
-
-void ParamTraits<net::HostPortPair>::Write(Message* m, const param_type& p) {
- WriteParam(m, p.host());
- WriteParam(m, p.port());
-}
-
-bool ParamTraits<net::HostPortPair>::Read(const Message* m,
- PickleIterator* iter,
- param_type* r) {
- std::string host;
- uint16 port;
- if (!ReadParam(m, iter, &host) || !ReadParam(m, iter, &port))
- return false;
-
- r->set_host(host);
- r->set_port(port);
- return true;
-}
-
-void ParamTraits<net::HostPortPair>::Log(const param_type& p, std::string* l) {
- l->append(p.ToString());
-}
-
-void ParamTraits<net::IPEndPoint>::Write(Message* m, const param_type& p) {
- WriteParam(m, p.address());
- WriteParam(m, p.port());
-}
-
-bool ParamTraits<net::IPEndPoint>::Read(const Message* m, PickleIterator* iter,
- param_type* p) {
- net::IPAddressNumber address;
- int port;
- if (!ReadParam(m, iter, &address) || !ReadParam(m, iter, &port))
- return false;
- if (address.size() &&
- address.size() != net::kIPv4AddressSize &&
- address.size() != net::kIPv6AddressSize) {
- return false;
- }
- *p = net::IPEndPoint(address, port);
- return true;
-}
-
-void ParamTraits<net::IPEndPoint>::Log(const param_type& p, std::string* l) {
- LogParam("IPEndPoint:" + p.ToString(), l);
-}
-
-void ParamTraits<content::PageState>::Write(
- Message* m, const param_type& p) {
- WriteParam(m, p.ToEncodedData());
-}
-
-bool ParamTraits<content::PageState>::Read(
- const Message* m, PickleIterator* iter, param_type* r) {
- std::string data;
- if (!ReadParam(m, iter, &data))
- return false;
- *r = content::PageState::CreateFromEncodedData(data);
- return true;
-}
-
-void ParamTraits<content::PageState>::Log(
- const param_type& p, std::string* l) {
- l->append("(");
- LogParam(p.ToEncodedData(), l);
- l->append(")");
-}
-
void ParamTraits<gfx::Point>::Write(Message* m, const gfx::Point& p) {
m->WriteInt(p.x());
m->WriteInt(p.y());
@@ -392,24 +262,3 @@ void ParamTraits<SkBitmap>::Log(const SkBitmap& p, std::string* l) {
}
} // namespace IPC
-
-// Generate param traits write methods.
-#include "ipc/param_traits_write_macros.h"
-namespace IPC {
-#undef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_
-#include "content/public/common/common_param_traits_macros.h"
-} // namespace IPC
-
-// Generate param traits read methods.
-#include "ipc/param_traits_read_macros.h"
-namespace IPC {
-#undef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_
-#include "content/public/common/common_param_traits_macros.h"
-} // namespace IPC
-
-// Generate param traits log methods.
-#include "ipc/param_traits_log_macros.h"
-namespace IPC {
-#undef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_
-#include "content/public/common/common_param_traits_macros.h"
-} // namespace IPC
« no previous file with comments | « ui/gfx/ipc/gfx_param_traits.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698