Move IPC traits for SkBitmap, gfx_geometry into ui/gfx/ipc

Move IPC traits for SkBitmap, gfx_geometry into ui/gfx/ipc

We need these outside of content (under ui/ozone), so move them. No
functional change.

BUG=377497
TEST=chrome --ozone-platform=gbm

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279825

[reed1, 2014-06-20 13:30:55]

https://codereview.chromium.org/343003003/diff/1/ui/gfx/ipc/gfx_param_traits.cc
File ui/gfx/ipc/gfx_param_traits.cc (right):

https://codereview.chromium.org/343003003/diff/1/ui/gfx/ipc/gfx_param_traits....
ui/gfx/ipc/gfx_param_traits.cc:17: SkBitmap::Config fConfig;
I think you can replace the first 3 fields with SkImageInfo

https://codereview.chromium.org/343003003/diff/1/ui/gfx/ipc/gfx_param_traits....
ui/gfx/ipc/gfx_param_traits.cc:34: if (total_pixels) {
This method could then become

    bitmap->installPixels(fInfo, pixels, rowbytes);

If you don't have an explicit rowbytes, you can use info.minRowBytes().

[spang, 2014-06-23 22:46:56]

On 2014/06/20 13:30:55, reed1 wrote:
>
https://codereview.chromium.org/343003003/diff/1/ui/gfx/ipc/gfx_param_traits.cc
> File ui/gfx/ipc/gfx_param_traits.cc (right):
> 
>
https://codereview.chromium.org/343003003/diff/1/ui/gfx/ipc/gfx_param_traits....
> ui/gfx/ipc/gfx_param_traits.cc:17: SkBitmap::Config fConfig;
> I think you can replace the first 3 fields with SkImageInfo

I am willing to update this code but I'd like to do that in a followup. This CL
is just moving the code to and will unblock other work.

I've uploaded https://codereview.chromium.org/354483006/ to tackle the
deprecation issues.

>
https://codereview.chromium.org/343003003/diff/1/ui/gfx/ipc/gfx_param_traits....
> ui/gfx/ipc/gfx_param_traits.cc:34: if (total_pixels) {
> This method could then become
> 
>     bitmap->installPixels(fInfo, pixels, rowbytes);

It looks like this will not copy the data into the heap, which would be a
problem if we shallow copy the received SkBitmap (which we do).

> 
> If you don't have an explicit rowbytes, you can use info.minRowBytes().

[Ben Goodger (Google), 2014-06-24 15:54:31]

lgtm

[kenrb, 2014-06-25 13:56:23]

ipc lgtm, but you need tsepez@ for common_param_traits.cc.

[Tom Sepez, 2014-06-25 16:55:55]

param traits LGTM.

[spang, 2014-06-25 16:58:22]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-06-25 17:00:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/spang@chromium.org/343003003/1

[spang, 2014-06-25 17:09:43]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-06-25 17:15:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/spang@chromium.org/343003003/20001

[spang, 2014-06-25 19:20:51]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-06-25 19:21:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/spang@chromium.org/343003003/40001

[commit-bot: I haz the power, 2014-06-25 21:31:12]

Change committed as 279825