Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 342993005: Fix parameter type for glGenTextures. (Closed)

Created:
6 years, 6 months ago by hj.r.chung
Modified:
6 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix parameter type for glGenTextures. First parameter for glGenTextures should be int(GLsizei). Plus some code cleanup for texture manager. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M gpu/command_buffer/service/texture_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
hj.r.chung
PTAL! This is just some cleanup.
6 years, 6 months ago (2014-06-20 01:43:52 UTC) #1
piman
lgtm
6 years, 6 months ago (2014-06-20 17:12:33 UTC) #2
hj.r.chung
On 2014/06/20 17:12:33, piman wrote: > lgtm Thanks!
6 years, 6 months ago (2014-06-23 01:27:09 UTC) #3
hj.r.chung
The CQ bit was checked by heejin.r.chung@samsung.com
6 years, 6 months ago (2014-06-23 01:27:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heejin.r.chung@samsung.com/342993005/1
6 years, 6 months ago (2014-06-23 01:27:58 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 04:26:07 UTC) #6
Message was sent while issue was closed.
Change committed as 279039

Powered by Google App Engine
This is Rietveld 408576698