Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 342993002: Allow blink.console or webkit.console in telemetry (Closed)

Created:
6 years, 6 months ago by dsinclair
Modified:
6 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, telemetry+watch_chromium.org, jam, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Allow blink.console or webkit.console in telemetry This is in preparation of me renaming the "webkit*" category to "blink*" in the blink codebase. Once that change has rolled into chromium I'll do another CL for chromium to remove the "webkit.console" entry. BUG=386847 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278700

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M content/test/gpu/gpu_tests/memory.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/measurements/image_decoding.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dsinclair
PTAL. kbr@ for the gpu_test/ ernstrm@ for the rest.
6 years, 6 months ago (2014-06-19 20:25:12 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
6 years, 6 months ago (2014-06-19 20:26:20 UTC) #2
ernstm
LGTM % comments+ticket regarding reference build update.
6 years, 6 months ago (2014-06-19 22:01:13 UTC) #3
ernstm
https://codereview.chromium.org/342993002/diff/20001/tools/perf/measurements/image_decoding.py File tools/perf/measurements/image_decoding.py (right): https://codereview.chromium.org/342993002/diff/20001/tools/perf/measurements/image_decoding.py#newcode30 tools/perf/measurements/image_decoding.py:30: tab.browser.StartTracing( Please add a TODO comment to remove the ...
6 years, 6 months ago (2014-06-19 22:01:24 UTC) #4
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 6 months ago (2014-06-19 23:02:00 UTC) #5
dsinclair
https://codereview.chromium.org/342993002/diff/20001/tools/perf/measurements/image_decoding.py File tools/perf/measurements/image_decoding.py (right): https://codereview.chromium.org/342993002/diff/20001/tools/perf/measurements/image_decoding.py#newcode30 tools/perf/measurements/image_decoding.py:30: tab.browser.StartTracing( On 2014/06/19 22:01:24, ernstm wrote: > Please add ...
6 years, 6 months ago (2014-06-19 23:02:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/342993002/40001
6 years, 6 months ago (2014-06-19 23:03:56 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 07:50:10 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 13:25:17 UTC) #9
Message was sent while issue was closed. 
Change committed as 278700

Powered by Google App Engine
This is Rietveld 408576698