Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 342983004: Fix a bug where QUIC ack frames were not bundled with crypto stream (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix a bug where QUIC ack frames were not bundled with crypto stream frames when there was a missing packet. Moved the code to ensure Crypto stream frames weren't sent with other retransmittable frames from CryptoStreamFrame into QuicPacketGenerator. Merge internal change: 69415222 R=ianswett@google.com, rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -33 lines) Patch
M net/quic/quic_connection.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_connection.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M net/quic/quic_connection_test.cc View 4 chunks +25 lines, -7 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 2 chunks +10 lines, -1 line 0 comments Download
M net/quic/quic_packet_generator_test.cc View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-19 19:09:57 UTC) #1
wtc
Patch set 1 LGTM.
6 years, 6 months ago (2014-06-19 19:42:14 UTC) #2
Ian Swett
lgtm
6 years, 6 months ago (2014-06-19 22:19:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/342983004/1
6 years, 6 months ago (2014-06-19 22:21:24 UTC) #4
ramant (doing other things)
The CQ bit was unchecked by rtenneti@chromium.org
6 years, 6 months ago (2014-06-19 22:42:28 UTC) #5
ramant (doing other things)
On 2014/06/19 22:21:24, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-19 22:44:03 UTC) #6
Ryan Hamilton
6 years, 6 months ago (2014-06-19 23:55:43 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698