Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 342963002: Revert of [DevTools] Add offset and scale to WebDeviceEmulationParams. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Revert of [DevTools] Add offset and scale to WebDeviceEmulationParams. (https://codereview.chromium.org/342953003/) Reason for revert: Broke compile. Original issue's description: > [DevTools] Add offset and scale to WebDeviceEmulationParams. > > This will be used to set offset/scale from DevTools protocol > instead of caluculating them in embedder. > > BUG=327641 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176506 TBR=pfeldman@chromium.org NOTREECHECKS=true NOTRY=true BUG=327641 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M public/web/WebDeviceEmulationParams.h View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dgozman
Created Revert of [DevTools] Add offset and scale to WebDeviceEmulationParams.
6 years, 6 months ago (2014-06-19 12:32:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/342963002/1
6 years, 6 months ago (2014-06-19 12:33:41 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 12:34:46 UTC) #3
Message was sent while issue was closed.
Change committed as 176507

Powered by Google App Engine
This is Rietveld 408576698