Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 342953003: [DevTools] Add offset and scale to WebDeviceEmulationParams. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

[DevTools] Add offset and scale to WebDeviceEmulationParams. This will be used to set offset/scale from DevTools protocol instead of caluculating them in embedder. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176509

Patch Set 1 #

Patch Set 2 : now with include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M public/web/WebDeviceEmulationParams.h View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
dgozman
Take a look please.
6 years, 6 months ago (2014-06-19 12:05:21 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-19 12:08:44 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-19 12:17:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/342953003/1
6 years, 6 months ago (2014-06-19 12:18:15 UTC) #4
commit-bot: I haz the power
Change committed as 176506
6 years, 6 months ago (2014-06-19 12:19:12 UTC) #5
dgozman
A revert of this CL has been created in https://codereview.chromium.org/342963002/ by dgozman@chromium.org. The reason for ...
6 years, 6 months ago (2014-06-19 12:32:25 UTC) #6
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-19 12:39:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/342953003/20001
6 years, 6 months ago (2014-06-19 12:40:22 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 12:57:12 UTC) #9
Message was sent while issue was closed.
Change committed as 176509

Powered by Google App Engine
This is Rietveld 408576698