Added sandbox_linux_unittests to ARM trybot

Added sandbox_linux_unittests to ARM trybot

Added sandbox_linux_unittests test to
linux_arm_cross_compile/linux_arm_tester builders on the
tryserver.chromium waterfall.

R=phajdan.jr@chromium.org
BUG=386445
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278626

[nodir, 2014-06-19 23:23:27]

sandbox_linux_unittests were isolated (http://crbug.com/384514)

[jln (very slow on Chromium), 2014-06-19 23:35:50]

https://codereview.chromium.org/342943007/diff/1/testing/buildbot/chromium_ar...
File testing/buildbot/chromium_arm.json (right):

https://codereview.chromium.org/342943007/diff/1/testing/buildbot/chromium_ar...
testing/buildbot/chromium_arm.json:3: "browser_tests_run"
Shouldn't you add sandbox_linux_unittests_run here as well?

[nodir, 2014-06-19 23:59:20]

https://codereview.chromium.org/342943007/diff/1/testing/buildbot/chromium_ar...
File testing/buildbot/chromium_arm.json (right):

https://codereview.chromium.org/342943007/diff/1/testing/buildbot/chromium_ar...
testing/buildbot/chromium_arm.json:3: "browser_tests_run"
On 2014/06/19 23:35:50, jln wrote:
> Shouldn't you add sandbox_linux_unittests_run here as well?

Done.

[jln (very slow on Chromium), 2014-06-20 00:02:15]

lgtm, thanks!

[nodir, 2014-06-20 00:39:58]

Build looks good
http://build.chromium.org/p/tryserver.chromium/builders/linux_arm_tester/buil...

[jln (very slow on Chromium), 2014-06-20 00:44:03]

https://codereview.chromium.org/342943007/diff/20001/testing/buildbot/chromiu...
File testing/buildbot/chromium_arm.json (right):

https://codereview.chromium.org/342943007/diff/20001/testing/buildbot/chromiu...
testing/buildbot/chromium_arm.json:8: "sandbox_linux_unittests"
Ohh, I forgot: is there a way here to add
--test-launcher-print-test-stdio=always ?

This is for instance what's in testing/buildbot/chromium_trybot.json and it's
really helpful to control what features the kernel supports.

[jln (very slow on Chromium), 2014-06-20 00:44:25]

On Thu, Jun 19, 2014 at 5:39 PM,  <nodir@chromium.org> wrote:
> Build looks good
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_arm_tester/buil...

Ahh, great news!

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Paweł Hajdan Jr., 2014-06-20 00:52:52]

LGTM

[nodir, 2014-06-20 01:03:53]

https://codereview.chromium.org/342943007/diff/20001/testing/buildbot/chromiu...
File testing/buildbot/chromium_arm.json (right):

https://codereview.chromium.org/342943007/diff/20001/testing/buildbot/chromiu...
testing/buildbot/chromium_arm.json:8: "sandbox_linux_unittests"
On 2014/06/20 00:44:03, jln wrote:
> Ohh, I forgot: is there a way here to add
> --test-launcher-print-test-stdio=always ?
> 
> This is for instance what's in testing/buildbot/chromium_trybot.json and it's
> really helpful to control what features the kernel supports.

Since currently there is no way to pass cmd line args from a builder to a tester
(only a test name), so we keep the cmd line args separately (terrible) the
chromium_isolate recipe. This will be fixed once http://crbug.com/361841 is
fixed

CL: https://codereview.chromium.org/344793011

I'll put the test filter there.

[jln (very slow on Chromium), 2014-06-20 01:06:31]

On 2014/06/20 01:03:53, nodir wrote:
>
https://codereview.chromium.org/342943007/diff/20001/testing/buildbot/chromiu...
> File testing/buildbot/chromium_arm.json (right):
> 
>
https://codereview.chromium.org/342943007/diff/20001/testing/buildbot/chromiu...
> testing/buildbot/chromium_arm.json:8: "sandbox_linux_unittests"
> On 2014/06/20 00:44:03, jln wrote:
> > Ohh, I forgot: is there a way here to add
> > --test-launcher-print-test-stdio=always ?
> > 
> > This is for instance what's in testing/buildbot/chromium_trybot.json and
it's
> > really helpful to control what features the kernel supports.
> 
> Since currently there is no way to pass cmd line args from a builder to a
tester
> (only a test name), so we keep the cmd line args separately (terrible) the
> chromium_isolate recipe. This will be fixed once http://crbug.com/361841 is
> fixed
> 
> CL: https://codereview.chromium.org/344793011
> 
> I'll put the test filter there.

Fantastic, thanks!

[nodir, 2014-06-20 01:07:17]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2014-06-20 01:10:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nodir@chromium.org/342943007/20001

[commit-bot: I haz the power, 2014-06-20 05:43:29]

Change committed as 278626