Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: LayoutTests/fast/dom/HTMLDialogElement/abspos-dialog-layout-expected.txt

Issue 342943002: Center fixpos <dialog> (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rm non-anchored-dialog-positioning-expected.txt Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/HTMLDialogElement/abspos-dialog-layout-expected.txt
diff --git a/LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt b/LayoutTests/fast/dom/HTMLDialogElement/abspos-dialog-layout-expected.txt
similarity index 57%
rename from LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt
rename to LayoutTests/fast/dom/HTMLDialogElement/abspos-dialog-layout-expected.txt
index 1cfbfb0c84b89576c6e1229b54d9456b59905b50..02101c9c704c5903c1371bbf6b95711ca48441de 100644
--- a/LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt
+++ b/LayoutTests/fast/dom/HTMLDialogElement/abspos-dialog-layout-expected.txt
@@ -1,19 +1,20 @@
-Tests positioning of non-anchored dialogs.
+Tests layout of absolutely positioned modal dialogs.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
showModal() should center in the viewport.
PASS dialog.getBoundingClientRect().top is centeredTop
-The computed top and bottom of a centered dialog should still have position auto
+The computed top and bottom of a centered dialog should still have position auto.
PASS window.getComputedStyle(dialog).top is "auto"
PASS window.getComputedStyle(dialog).bottom is "auto"
Dialog should be recentered if showModal() is called after close().
PASS dialog.getBoundingClientRect().top is centeredTop
-Dialog should not be recentered on a relayout.
+Dialog should not recenter on relayout.
PASS dialog.getBoundingClientRect().top is expectedTop
A tall dialog should be positioned at the top of the viewport.
@@ -22,43 +23,30 @@ PASS dialog.getBoundingClientRect().top is 0
The dialog should be centered regardless of the presence of a horizontal scrollbar.
PASS dialog.getBoundingClientRect().top is centeredTop
-Test that centering works when dialog is inside positioned containers.
+Centering should work when dialog is inside positioned containers.
PASS dialog.getBoundingClientRect().top is centeredTop
PASS dialog.getBoundingClientRect().top is centeredTop
-Dialog's position should survive after becoming display:none temporarily.
+A centered dialog's position should survive becoming display:none temporarily.
PASS dialog.getBoundingClientRect().top is expectedTop
-Dialog loses centering position when removed from document.
+Dialog should lose centering when removed from the document.
PASS dialog.getBoundingClientRect().top is relativeContainer.getBoundingClientRect().top
Dialog's specified position should survive after close() and showModal().
PASS dialog.getBoundingClientRect().top is expectedTop
-Dialog is recentered if showModal() is called after removing 'open'
+Dialog should be recentered if showModal() is called after removing 'open'.
PASS dialog.getBoundingClientRect().top is centeredTop
Dialog should not be centered if showModal() was called when an ancestor had display 'none'.
-PASS dialog.getBoundingClientRect().top is expectedTop
+PASS dialog.getBoundingClientRect().top is document.body.getBoundingClientRect().bottom
-Test setting 'top' on an abspos modal dialog
+A dialog with specified 'top' should be positioned as usual
PASS dialog.getBoundingClientRect().top + window.scrollY is offset
-Test setting 'bottom' on an abspos modal dialog
+A dialog with specified 'bottom' should be positioned as usual
PASS dialog.getBoundingClientRect().bottom + window.scrollY is window.innerHeight - offset
-
-Test fixed position for a modal dialog
-PASS dialog.getBoundingClientRect().top is offset
-
-Test absolute position for a non-modal dialog
-PASS dialog.getBoundingClientRect().top is relativeContainer.getBoundingClientRect().top + offset
-
-Test static position for a non-modal dialog
-PASS dialog.getBoundingClientRect().top is relativeContainer.getBoundingClientRect().top
-
-Test relative position for a non-modal dialog
-PASS dialog.getBoundingClientRect().top is relativeContainer.getBoundingClientRect().top + offset
-PASS dialog.getBoundingClientRect().left is relativeContainer.getBoundingClientRect().left + offset
PASS successfullyParsed is true
TEST COMPLETE

Powered by Google App Engine
This is Rietveld 408576698