LayoutTests/fast/dom/HTMLDialogElement/non-modal-dialog-layout.html - Issue 342943002: Center fixpos <dialog>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLDialogElement/non-modal-dialog-layout.html

Issue 342943002: Center fixpos <dialog> (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt ('k') | LayoutTests/fast/dom/HTMLDialogElement/non-modal-dialog-layout-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <link href="resources/dialog-layout.css" rel="stylesheet">

	3 <script src="../../../resources/js-test.js"></script>

	4 <div id="absolute-div">

	5 <div id="relative-div">

	6 <dialog id="dialog">It is my dialog.</dialog>

	7 </div>

	8 </div>

	9 <script>

	10 description('Tests layout of non-modal dialogs.');

	11

	12 dialog = document.querySelector('#dialog');

	13 div = document.querySelector('#div-dialog');

	14 relativeContainer = document.querySelector('#relative-div');

	15 offset = 50;

	16 dialog.style.top = offset + 'px';

	17 dialog.style.left = offset + 'px';

	18

	19 (function() {

	20 debug('<br>Test absolute position');

	21 dialog.style.position = 'absolute';

	22 dialog.show();

	23 shouldBe('dialog.getBoundingClientRect().top', 'relativeContainer.getBoundin gClientRect().top + offset');

	24 shouldBe('dialog.getBoundingClientRect().left', 'relativeContainer.getBoundi ngClientRect().left + offset');

	25 }());

	26

	27 (function() {

	28 debug('<br>Test static position');

	29 dialog.style.position = 'static';

	30 dialog.show();

	31 shouldBe('dialog.getBoundingClientRect().top', 'relativeContainer.getBoundin gClientRect().top');

	32 shouldBe('dialog.getBoundingClientRect().left', 'relativeContainer.getBoundi ngClientRect().left');

	33 dialog.close();

	34 }());

	35

	36 (function() {

	37 debug('<br>Test relative position');

	38 dialog.style.position = 'relative';

	39 dialog.show();

	40 shouldBe('dialog.getBoundingClientRect().top', 'relativeContainer.getBoundin gClientRect().top + offset');

	41 shouldBe('dialog.getBoundingClientRect().left', 'relativeContainer.getBoundi ngClientRect().left + offset');

	42 dialog.close();

	43 }());

	44

	45 (function() {

	46 debug('<br>Test fixed position');

	47 dialog.style.position = 'fixed';

	48 dialog.show();

	49 shouldBe('dialog.getBoundingClientRect().top', 'offset');

	50 shouldBe('dialog.getBoundingClientRect().left', 'offset');

	51 dialog.close();

	52 }());

	53 </script>

OLD	NEW