Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: Source/core/html/parser/AtomicHTMLToken.h

Issue 342933003: Remove an unneccessary FIXME comment for HTMLToken (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/parser/CompactHTMLToken.cpp » ('j') | Source/core/html/parser/HTMLToken.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/parser/AtomicHTMLToken.h
diff --git a/Source/core/html/parser/AtomicHTMLToken.h b/Source/core/html/parser/AtomicHTMLToken.h
index dc0e54eb48ba86845404c4648c690af4547c2af4..68aa2ff1543022f7213e4dba299a8ac4dd47fa1e 100644
--- a/Source/core/html/parser/AtomicHTMLToken.h
+++ b/Source/core/html/parser/AtomicHTMLToken.h
@@ -96,14 +96,14 @@ public:
}
// FIXME: Distinguish between a missing public identifer and an empty one.
- Vector<UChar>& publicIdentifier() const
+ String& publicIdentifier() const
{
ASSERT(m_type == HTMLToken::DOCTYPE);
return m_doctypeData->m_publicIdentifier;
}
// FIXME: Distinguish between a missing system identifer and an empty one.
- Vector<UChar>& systemIdentifier() const
+ String& systemIdentifier() const
{
ASSERT(m_type == HTMLToken::DOCTYPE);
return m_doctypeData->m_systemIdentifier;
@@ -153,9 +153,9 @@ public:
m_name = AtomicString(token.data());
m_doctypeData = adoptPtr(new DoctypeData());
m_doctypeData->m_hasPublicIdentifier = true;
- append(m_doctypeData->m_publicIdentifier, token.publicIdentifier());
+ m_doctypeData->m_publicIdentifier = token.publicIdentifier();
m_doctypeData->m_hasSystemIdentifier = true;
- append(m_doctypeData->m_systemIdentifier, token.systemIdentifier());
+ m_doctypeData->m_systemIdentifier = token.systemIdentifier();
m_doctypeData->m_forceQuirks = token.doctypeForcesQuirks();
break;
case HTMLToken::EndOfFile:
« no previous file with comments | « no previous file | Source/core/html/parser/CompactHTMLToken.cpp » ('j') | Source/core/html/parser/HTMLToken.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698