Fix wrong result from IsKnownUnaccelerated() even if there are H/W acceleratable codecs.

Fix wrong result from IsKnownUnaccelerated() even if there are H/W acceleratable codecs.

Android's MediaCodec can return several codecs for given codec type.
If H/W acceleratable codec is not top of the list, it might return false.
Although device is supporting H/W accelerating for given codec type,
IsKnownUnaccelerated() returns wrong result.

BUG=386484
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279297

[KhNo, 2014-06-19 07:40:38]

The CQ bit was checked by keonho07.kim@samsung.com

[KhNo, 2014-06-19 07:40:39]

The CQ bit was unchecked by keonho07.kim@samsung.com

[KhNo, 2014-06-19 09:45:32]

Please review this patch set.

[wjia(left Chromium), 2014-06-19 17:20:06]

I left Chrome project. You can either wait for Min or find another reviewer.

[KhNo, 2014-06-20 02:16:06]

Dale Curtis,
Could you review this patch?

[DaleCurtis, 2014-06-20 18:00:31]

https://codereview.chromium.org/342933002/diff/1/media/base/android/media_cod...
File media/base/android/media_codec_bridge.cc (right):

https://codereview.chromium.org/342933002/diff/1/media/base/android/media_cod...
media/base/android/media_codec_bridge.cc:170: bool IsKnownUnaccelerated = true;
revert.

https://codereview.chromium.org/342933002/diff/1/media/base/android/media_cod...
media/base/android/media_codec_bridge.cc:182: IsKnownUnaccelerated = false;
Just change this to "if (!...) return false;"

https://codereview.chromium.org/342933002/diff/1/media/base/android/media_cod...
media/base/android/media_codec_bridge.cc:185: return IsKnownUnaccelerated;
revert.

[KhNo, 2014-06-21 15:29:15]

PTAL, Thanks for your review.

https://codereview.chromium.org/342933002/diff/1/media/base/android/media_cod...
File media/base/android/media_codec_bridge.cc (right):

https://codereview.chromium.org/342933002/diff/1/media/base/android/media_cod...
media/base/android/media_codec_bridge.cc:170: bool IsKnownUnaccelerated = true;
On 2014/06/20 18:00:31, DaleCurtis wrote:
> revert.

Done.

https://codereview.chromium.org/342933002/diff/1/media/base/android/media_cod...
media/base/android/media_codec_bridge.cc:182: IsKnownUnaccelerated = false;
On 2014/06/20 18:00:31, DaleCurtis wrote:
> Just change this to "if (!...) return false;"

Thanks DaleCurtis.

https://codereview.chromium.org/342933002/diff/1/media/base/android/media_cod...
media/base/android/media_codec_bridge.cc:185: return IsKnownUnaccelerated;
On 2014/06/20 18:00:31, DaleCurtis wrote:
> revert.

Done.

[DaleCurtis, 2014-06-23 18:49:12]

lgtm

[KhNo, 2014-06-24 00:19:14]

The CQ bit was checked by keonho07.kim@samsung.com

[commit-bot: I haz the power, 2014-06-24 00:19:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/342933002/20001

[commit-bot: I haz the power, 2014-06-24 03:33:34]

Change committed as 279297