Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 342923002: Remove GL query processing from DrawElements/DrawArrays. (Closed)

Created:
6 years, 6 months ago by vmiura
Modified:
6 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove GL query processing from DrawElements/DrawArrays. Polling GL queries is taking ~7us each time on Android. Processing queries from ::DrawElements & ::DrawArrays may not be a good idea as 50 to 100 draw calls per-frame with GPU rendering is common i.e. 350~700us, and more so as we aim for handling higher draw call counts in the future. Pending queries are still polled in the following cases: - After glFlush(). - After glFinish(). - After processing any GpuCommandBufferStub IPC message. - As delayed work, at up to 1000Hz. BUG=385937 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vmiura
ptal
6 years, 6 months ago (2014-06-19 06:53:20 UTC) #1
reveman
lgtm
6 years, 6 months ago (2014-06-19 14:17:35 UTC) #2
piman
lgtm
6 years, 6 months ago (2014-06-19 19:18:01 UTC) #3
no sievers
lgtm
6 years, 6 months ago (2014-06-19 23:00:29 UTC) #4
vmiura
The CQ bit was checked by vmiura@chromium.org
6 years, 6 months ago (2014-06-19 23:04:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmiura@chromium.org/342923002/1
6 years, 6 months ago (2014-06-19 23:06:14 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-19 23:19:13 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 23:50:16 UTC) #8
Message was sent while issue was closed.
Change committed as 278533

Powered by Google App Engine
This is Rietveld 408576698