Issue 342903002: Disable DirectWrite for pre-release versions of Windows 7

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342903002: Disable DirectWrite for pre-release versions of Windows 7 (Closed)

Created:
6 years, 6 months ago by cpu_(ooo_6.6-7.5)

Modified:
6 years, 6 months ago

Reviewers:
jam, scottmg

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable DirectWrite for pre-release versions of Windows 7 It crashes while warming up the sandbox, deep inside QueryInterface BUG=385781 TEST=see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278600

Patch Set 1 #

Total comments: 1

Patch Set 2 : nits #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	content/common/sandbox_win.cc	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

scottmg

nice, lgtm https://codereview.chromium.org/342903002/diff/1/content/common/sandbox_win.cc File content/common/sandbox_win.cc (right): https://codereview.chromium.org/342903002/diff/1/content/common/sandbox_win.cc#newcode569 content/common/sandbox_win.cc:569: // 2670838, so a Win7 check is ...

6 years, 6 months ago (2014-06-19 03:26:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/342903002/20001

6 years, 6 months ago (2014-06-19 18:11:37 UTC) #6

Message was sent while issue was closed.

Change committed as 278600

Expand Messages | Collapse Messages