Using Enum in place of bool for better code readability

Source/platform/fonts/FontDescription.h

Index: Source/platform/fonts/FontDescription.h
diff --git a/Source/platform/fonts/FontDescription.h b/Source/platform/fonts/FontDescription.h
index 9cefae0436a002fe2cde08e1388cad87c6c91946..71215f25bc3de086e5e19964691e677ded344bc7 100644
--- a/Source/platform/fonts/FontDescription.h
+++ b/Source/platform/fonts/FontDescription.h
@@ -26,6 +26,7 @@
 #define FontDescription_h
 
 #include "platform/FontFamilyNames.h"
+#include "platform/fonts/FixedPitchFontType.h"
 #include "platform/fonts/FontCacheKey.h"
 #include "platform/fonts/FontFamily.h"
 #include "platform/fonts/FontFeatureSettings.h"
@@ -102,7 +103,12 @@ public:
     GenericFamilyType genericFamily() const { return static_cast<GenericFamilyType>(m_genericFamily); }
 
     // only use fixed default size when there is only one font family, and that family is "monospace"
-    bool useFixedDefaultSize() const { return genericFamily() == MonospaceFamily && !family().next() && family().family() == FontFamilyNames::webkit_monospace; }
+    FixedPitchFontType useFixedDefaultSize() const

[Inactive, 2014/06/26 19:43:11]

Seems a bit weird to have a use*() method not returning a boolean.

[h.joshi, 2014/06/27 06:55:27]

Done, changes method name in this file and also in CSSComputedStyleDeclaration.h

+    {
+        if (genericFamily() == MonospaceFamily && !family().next() && family().family() == FontFamilyNames::webkit_monospace)
+            return FixedPitchFont;
+        return NonFixedPitchFont;
+    }
     Kerning kerning() const { return static_cast<Kerning>(m_kerning); }
     LigaturesState commonLigaturesState() const { return static_cast<LigaturesState>(m_commonLigaturesState); }
     LigaturesState discretionaryLigaturesState() const { return static_cast<LigaturesState>(m_discretionaryLigaturesState); }