Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: Source/core/css/FontSize.h

Issue 342883004: Using Enum in place of bool for better code readability (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Comment fixes Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 * 19 *
20 */ 20 */
21 21
22 #ifndef FontSize_h 22 #ifndef FontSize_h
23 #define FontSize_h 23 #define FontSize_h
24 24
25 #include "core/CSSValueKeywords.h"
26 #include "platform/fonts/FixedPitchFontType.h"
27
25 namespace WebCore { 28 namespace WebCore {
26 29
27 class Document; 30 class Document;
28 31
29 enum ESmartMinimumForFontSize { DoNotUseSmartMinimumForFontSize, UseSmartMinimum ForFontFize }; 32 enum ESmartMinimumForFontSize { DoNotUseSmartMinimumForFontSize, UseSmartMinimum ForFontFize };
30 33
31 class FontSize { 34 class FontSize {
32 private: 35 private:
33 FontSize() 36 FontSize()
34 { 37 {
35 } 38 }
36 39
37 public: 40 public:
38 static float getComputedSizeFromSpecifiedSize(const Document*, float zoomFac tor, bool isAbsoluteSize, float specifiedSize, ESmartMinimumForFontSize = UseSma rtMinimumForFontFize); 41 static float getComputedSizeFromSpecifiedSize(const Document*, float zoomFac tor, bool isAbsoluteSize, float specifiedSize, ESmartMinimumForFontSize = UseSma rtMinimumForFontFize);
39 42
40 // Given a CSS keyword in the range (xx-small to -webkit-xxx-large), this fu nction will return 43 // Given a CSS keyword in the range (xx-small to -webkit-xxx-large), this fu nction will return
41 // the correct font size scaled relative to the user's default (medium). 44 // the correct font size scaled relative to the user's default (medium).
42 static float fontSizeForKeyword(const Document*, int keyword, bool shouldUse FixedDefaultSize); 45 static float fontSizeForKeyword(const Document*, CSSValueID keyword, FixedPi tchFontType);
43 46
44 // Given a font size in pixel, this function will return legacy font size be tween 1 and 7. 47 // Given a font size in pixel, this function will return legacy font size be tween 1 and 7.
45 static int legacyFontSize(const Document*, int pixelFontSize, bool shouldUse FixedDefaultSize); 48 static int legacyFontSize(const Document*, int pixelFontSize, FixedPitchFont Type);
46 }; 49 };
47 50
48 } // namespace WebCore 51 } // namespace WebCore
49 52
50 #endif // FontSize_h 53 #endif // FontSize_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698