Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 342863003: Add WebServiceWorkerErrorType::ErrorTypeAbort (Closed)

Created:
6 years, 6 months ago by falken
Modified:
6 years, 6 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Add WebServiceWorkerErrorType::ErrorTypeAbort This is needed for removing --enable-service-worker (https://codereview.chromium.org/339973003/). Chromium-side currently returns ErrorTypeDisabled for both "SW is disabled" and "SWContextCore was destroyed during shutdown" when handling a registration request. Since the former will no longer happen, add a generic operation aborted error for the latter. BUG=365201 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerError.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M public/platform/WebServiceWorkerError.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
falken
r? This patch is needed for the --enable-service-worker removal patch, particularly this file: https://codereview.chromium.org/339973003/diff/1/content/browser/service_worker/service_worker_dispatcher_host.cc
6 years, 6 months ago (2014-06-19 01:42:25 UTC) #1
dominicc (has gone to gerrit)
On 2014/06/19 01:42:25, falken wrote: > r? > > This patch is needed for the ...
6 years, 6 months ago (2014-06-19 06:45:15 UTC) #2
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-19 06:45:17 UTC) #3
dominicc (has gone to gerrit)
The CQ bit was unchecked by dominicc@chromium.org
6 years, 6 months ago (2014-06-19 06:45:25 UTC) #4
falken
+tkent: can you please review as public/ OWNER?
6 years, 6 months ago (2014-06-19 06:47:24 UTC) #5
tkent
lgtm
6 years, 6 months ago (2014-06-19 07:15:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/342863003/1
6 years, 6 months ago (2014-06-19 07:16:35 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 09:45:17 UTC) #8
Message was sent while issue was closed.
Change committed as 176500

Powered by Google App Engine
This is Rietveld 408576698