Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 342843002: Revert of remove guarded code - there are no more callers (Closed)

Created:
6 years, 6 months ago by reed2
Modified:
6 years, 6 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of remove guarded code - there are no more callers (https://codereview.chromium.org/343783002/) Reason for revert: webkit still uses getTotalClip -- need to find where they define the guard. ../../skia/ext/skia_utils_mac.mm:400:42: error: no member named 'getTotalClip' in 'SkCanvas' const SkRegion& clipRgn = canvas_->getTotalClip(); ~~~~~~~ ^ Original issue's description: > remove guarded code - there are no more callers > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c5d5cf9489977aa6fba077d1dc242029fbb4859e TBR=scroggo@google.com,reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9f0147143fbedba10bdae496d812a14995304924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
M include/core/SkCanvas.h View 1 chunk +9 lines, -0 lines 0 comments Download
M include/effects/SkLayerRasterizer.h View 3 chunks +26 lines, -4 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M src/core/SkPaintPriv.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/effects/SkLayerRasterizer.cpp View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed2
Created Revert of remove guarded code - there are no more callers
6 years, 6 months ago (2014-06-18 22:50:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/342843002/1
6 years, 6 months ago (2014-06-18 22:51:15 UTC) #2
commit-bot: I haz the power
Change committed as 9f0147143fbedba10bdae496d812a14995304924
6 years, 6 months ago (2014-06-18 22:51:25 UTC) #3
fmalita_google_do_not_use
Chromium defines the guard in skia/: skia/BUILD.gn: "SK_SUPPORT_LEGACY_GETTOTALCLIP", skia/skia_common.gypi: 'SK_SUPPORT_LEGACY_GETTOTALCLIP',
6 years, 6 months ago (2014-06-18 23:09:56 UTC) #4
fmalita_google_do_not_use
6 years, 6 months ago (2014-06-18 23:18:25 UTC) #5
Message was sent while issue was closed.
> ../../skia/ext/skia_utils_mac.mm:400:42: error: no member named 'getTotalClip'
in 'SkCanvas'
> const SkRegion& clipRgn = canvas_->getTotalClip();
> ~~~~~~~ ^

Did we just find another client for getCurrentClip()? :)

Powered by Google App Engine
This is Rietveld 408576698