chrome/browser/ui/autofill/autofill_popup_controller_impl.cc - Issue 342833002: [Password Generation] Update Aura UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 342833002: [Password Generation] Update Aura UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

index c0cbd53bf3724c2c6b64e1d3a638092994320e6e..c82477c6c7629aa3abeaa0449d097ea3a967daac 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

@@ -607,8 +607,8 @@ void AutofillPopupControllerImpl::UpdatePopupBounds() {

int popup_required_width = GetDesiredPopupWidth();

Evan Stade 2014/07/15 22:46:28 I don't understand what "required" means here. s/r

Garrett Casto 2014/07/16 07:38:23 Done.

int popup_height = GetDesiredPopupHeight();

- popup_bounds_ = controller_common_->GetPopupBounds(popup_height,

- popup_required_width);

+ popup_bounds_ = controller_common_->GetPopupBounds(popup_required_width,

+ popup_height);

}

#endif // !defined(OS_ANDROID)