[Password Generation] Update Aura UI

chrome/browser/ui/autofill/password_generation_popup_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/password_generation_popup_view.h"
 
 namespace autofill {
 
 const SkColor PasswordGenerationPopupView::kExplanatoryTextBackgroundColor =
     SkColorSetRGB(0xF5, 0xF5, 0xF5);
 const SkColor PasswordGenerationPopupView::kExplanatoryTextColor =
     SkColorSetRGB(0x66, 0x66, 0x66);
 const SkColor PasswordGenerationPopupView::kDividerColor =
     SkColorSetRGB(0xE9, 0xE9, 0xE9);
 const SkColor PasswordGenerationPopupView::kLinkColor =

[Evan Stade, 2014/06/19 00:16:35]

I have a feeling these colors should either be deleted and replaced with values
from the native theme, or moved into the native theme. (Why is the link color
different here than elsewhere in chrome?)

[Garrett Casto, 2014/06/20 23:47:01]

Rebecca should hopefully be able to give a better answer here. I'm assuming that
Chrome is moving towards a different UI style but isn't going to change the
entire UI all at once.

FYI, it looks like the default is in ui::Link::GetDefaultEnabledColor(), not in
the theme for whatever reason. Your point obviously still stands.

[Evan Stade, 2014/06/23 18:20:40]

I think it would be good to make sure that assumption is correct. Hardcoded
values create inconsistencies and can break themes.
from native_theme.h:

    // TODO(benrg): move other hardcoded colors here.

-    SkColorSetRGB(0x55, 0x59, 0xFE);
+    SkColorSetRGB(0x55, 0x95, 0xFE);
 
 }  // namespace autofill