Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 342823002: Prevents windows that cannot snap from snapping using a keyboard accelerator (Closed)

Created:
6 years, 6 months ago by varkha
Modified:
6 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Prevents windows that cannot snap from snapping using a keyboard accelerator BUG=386254 TEST=Open a non-resizable app such as a calculator. Alt+] should not snap it. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
varkha
oshima@, can you please take a look? This probably was prevented before the window state ...
6 years, 6 months ago (2014-06-18 21:25:55 UTC) #1
oshima
lgtm
6 years, 6 months ago (2014-06-18 21:34:11 UTC) #2
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 6 months ago (2014-06-18 21:34:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/342823002/1
6 years, 6 months ago (2014-06-18 21:36:48 UTC) #4
oshima
On 2014/06/18 21:34:34, varkha wrote: > The CQ bit was checked by mailto:varkha@chromium.org btw, I ...
6 years, 6 months ago (2014-06-18 21:36:56 UTC) #5
varkha
On 2014/06/18 21:36:56, oshima wrote: > On 2014/06/18 21:34:34, varkha wrote: > > The CQ ...
6 years, 6 months ago (2014-06-18 21:42:49 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 04:34:34 UTC) #7
Message was sent while issue was closed.
Change committed as 278273

Powered by Google App Engine
This is Rietveld 408576698