Trying to get review for one-line change in Patch Set 3

Adding content back into App Gallery and Middleware pages.

Doing this via HTML for now; back to RST after I/O.

R=binji@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278552

[egilmore1, 2014-06-18 21:32:23]

This CL is in response to concerns that these pages were not converted from
devsite, and have been content-free since the conversion.

Thanks for reviewing!

[binji, 2014-06-18 21:37:47]

lgtm, can you clean up the commit message before you land? Right now it is a bit
verbose :)

[egilmore1, 2014-06-18 23:04:25]

On 2014/06/18 21:37:47, binji wrote:
> lgtm, can you clean up the commit message before you land? Right now it is a
bit
> verbose :)

Yes, it got verbose by pulling in all my commit descriptions :)  Thanks Ben!

[egilmore1, 2014-06-18 23:04:38]

The CQ bit was checked by egilmore@google.com

[commit-bot: I haz the power, 2014-06-18 23:05:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/egilmore@chromium.org/342773003/1

[binji, 2014-06-18 23:13:01]

On 2014/06/18 23:05:56, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/egilmore@chromium.org/342773003/1

I don't think the binary files will work with the CQ. I can land this change
manually, it doesn't need to run on the trybots anyway.

[native-client-reviews_googlegroups.com, 2014-06-18 23:14:14]

Ah -- if you don't mind taking care of it manually, that would be awesome.

Thanks for all your help on this Ben!


On Wed, Jun 18, 2014 at 4:13 PM, <binji@chromium.org> wrote:

> On 2014/06/18 23:05:56, I haz the power (commit-bot) wrote:
>
>> CQ is trying da patch. Follow status at
>>   https://chromium-status.appspot.com/cq/egilmore@
>> chromium.org/342773003/1
>>
>
> I don't think the binary files will work with the CQ. I can land this
> change
> manually, it doesn't need to run on the trybots anyway.
>
> https://codereview.chromium.org/342773003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[chromium-reviews, 2014-06-18 23:14:14]

Ah -- if you don't mind taking care of it manually, that would be awesome.

Thanks for all your help on this Ben!


On Wed, Jun 18, 2014 at 4:13 PM, <binji@chromium.org> wrote:

> On 2014/06/18 23:05:56, I haz the power (commit-bot) wrote:
>
>> CQ is trying da patch. Follow status at
>>   https://chromium-status.appspot.com/cq/egilmore@
>> chromium.org/342773003/1
>>
>
> I don't think the binary files will work with the CQ. I can land this
> change
> manually, it doesn't need to run on the trybots anyway.
>
> https://codereview.chromium.org/342773003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[binji, 2014-06-18 23:49:08]

Hm, I can't seem to patch in the CL. It is missing some of the images.

The download link (https://codereview.chromium.org/tarball/342773003/1) has the
patch, but it doesn't have all necessary files.

[native-client-reviews_googlegroups.com, 2014-06-19 00:02:33]

AFAGIC (as far as git is concerned), all my additions are committed.  Can
you easily generate a list of the missing files Ben?  Otherwise, I can go
in and try to eyeball the diff and try to force the missing files into to
the CL.


On Wed, Jun 18, 2014 at 4:49 PM, <binji@chromium.org> wrote:

> Hm, I can't seem to patch in the CL. It is missing some of the images.
>
> The download link (https://codereview.chromium.org/tarball/342773003/1)
> has the
> patch, but it doesn't have all necessary files.
>
> https://codereview.chromium.org/342773003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[chromium-reviews, 2014-06-19 00:02:33]

AFAGIC (as far as git is concerned), all my additions are committed.  Can
you easily generate a list of the missing files Ben?  Otherwise, I can go
in and try to eyeball the diff and try to force the missing files into to
the CL.


On Wed, Jun 18, 2014 at 4:49 PM, <binji@chromium.org> wrote:

> Hm, I can't seem to patch in the CL. It is missing some of the images.
>
> The download link (https://codereview.chromium.org/tarball/342773003/1)
> has the
> patch, but it doesn't have all necessary files.
>
> https://codereview.chromium.org/342773003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-06-19 05:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 05:07:25]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/18795)

[binji, 2014-06-19 16:59:18]

On 2014/06/19 00:02:33, chromium-reviews wrote:
> AFAGIC (as far as git is concerned), all my additions are committed.  Can
> you easily generate a list of the missing files Ben?  Otherwise, I can go
> in and try to eyeball the diff and try to force the missing files into to
> the CL.

The following are missing:
bastion.png
battle-for-wesnoth.png
fmod_logo.png
qt_logo.png
running-fred.png

It probably just screwed up during the upload step. It happens sometimes...

> 
> 
> On Wed, Jun 18, 2014 at 4:49 PM, <mailto:binji@chromium.org> wrote:
> 
> > Hm, I can't seem to patch in the CL. It is missing some of the images.
> >
> > The download link (https://codereview.chromium.org/tarball/342773003/1)
> > has the
> > patch, but it doesn't have all necessary files.
> >
> > https://codereview.chromium.org/342773003/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[binji, 2014-06-20 00:38:36]

Committed patchset #2 manually as r278552 (presubmit successful).