Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 342773002: Spoken Feedback Browsertest: AddBookmark test and some structural changes (Closed)

Created:
6 years, 6 months ago by kathrelkeld
Modified:
6 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Spoken Feedback Browsertest: AddBookmark test and some structural changes - restructured existing code to allow some tests to run in only normal mode - added AddBookmark test to check ChromeVox while adding a bookmark - switched SendKeyPress to SendKeyPressToWindowSync throughout all tests - reordered expected ChromeVox messages and reenabled TypeInOmnibox test BUG=None TEST=this R=dmazzoni@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -26 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 7 chunks +90 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kathrelkeld
6 years, 6 months ago (2014-06-18 21:35:49 UTC) #1
dmazzoni
lgtm
6 years, 6 months ago (2014-06-18 22:19:11 UTC) #2
kathrelkeld
The CQ bit was checked by kathrelkeld@chromium.org
6 years, 6 months ago (2014-06-18 23:54:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kathrelkeld@chromium.org/342773002/1
6 years, 6 months ago (2014-06-18 23:55:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 02:12:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/164012)
6 years, 6 months ago (2014-06-19 02:12:33 UTC) #6
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 6 months ago (2014-06-19 05:01:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kathrelkeld@chromium.org/342773002/1
6 years, 6 months ago (2014-06-19 05:05:07 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 07:54:29 UTC) #9
Message was sent while issue was closed.
Change committed as 278304

Powered by Google App Engine
This is Rietveld 408576698