Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 342763002: Add tracing to ResourceLoadPriorityOptimizer::updateAllImageResourcePriorities (Closed)

Created:
6 years, 6 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 6 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Add tracing to ResourceLoadPriorityOptimizer::updateAllImageResourcePriorities I discovered while looking into LayoutState's fast coordinate mapping that we can potentially do a lot of localToAbsolute calls to determine if images are onscreen in ResourceLoadPriorityOptimizer. These calls are out-of-band from the RenderTree walk done during layout, so don't benefit from the fast- lookups. That made me believe the function may actually be expensive. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176455

Patch Set 1 #

Patch Set 2 : Fix includes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/fetch/ResourceLoadPriorityOptimizer.cpp View 1 2 chunks +3 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
leviw_travelin_and_unemployed
6 years, 6 months ago (2014-06-18 18:35:08 UTC) #1
dsinclair
https://codereview.chromium.org/342763002/diff/20001/Source/core/fetch/ResourceLoadPriorityOptimizer.cpp File Source/core/fetch/ResourceLoadPriorityOptimizer.cpp (right): https://codereview.chromium.org/342763002/diff/20001/Source/core/fetch/ResourceLoadPriorityOptimizer.cpp#newcode81 Source/core/fetch/ResourceLoadPriorityOptimizer.cpp:81: TRACE_EVENT0("webkit", "ResourceLoadPriorityOptimizer::updateAllImageResourcePriorities"); I've seen some of these as "webkit" ...
6 years, 6 months ago (2014-06-18 18:37:53 UTC) #2
esprehn
lgtm https://codereview.chromium.org/342763002/diff/20001/Source/core/fetch/ResourceLoadPriorityOptimizer.cpp File Source/core/fetch/ResourceLoadPriorityOptimizer.cpp (right): https://codereview.chromium.org/342763002/diff/20001/Source/core/fetch/ResourceLoadPriorityOptimizer.cpp#newcode81 Source/core/fetch/ResourceLoadPriorityOptimizer.cpp:81: TRACE_EVENT0("webkit", "ResourceLoadPriorityOptimizer::updateAllImageResourcePriorities"); Lets use webkit for now, and ...
6 years, 6 months ago (2014-06-18 19:17:06 UTC) #3
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 6 months ago (2014-06-18 19:40:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/342763002/20001
6 years, 6 months ago (2014-06-18 19:40:34 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 21:25:18 UTC) #6
Message was sent while issue was closed.
Change committed as 176455

Powered by Google App Engine
This is Rietveld 408576698