Source/bindings/tests/results/V8TestOverloadedConstructors.cpp - Issue 34273002: Remove UnusedParam.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

Issue 34273002: Remove UnusedParam.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove unnecessary ALLOW_UNUSED from the binding generator Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/interface.cpp ('K') | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

diff --git a/Source/bindings/tests/results/V8TestOverloadedConstructors.cpp b/Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

index c627af9f6bcc293a07e0068d0143872107d95d78..9f03263ed42ac28b70e71d51184d5add1e88b7c8 100644

--- a/Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

+++ b/Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

@@ -46,7 +46,6 @@

#include "core/dom/ContextFeatures.h"

#include "core/dom/Document.h"

#include "platform/TraceEvent.h"

-#include "wtf/UnusedParam.h"

namespace WebCore {

@@ -170,13 +169,10 @@ static v8::Handle<v8::FunctionTemplate> ConfigureV8TestOverloadedConstructorsTem

0, 0,

isolate, currentWorldType);

- UNUSED_PARAM(defaultSignature);

functionTemplate->SetCallHandler(V8TestOverloadedConstructors::constructorCallback);

functionTemplate->SetLength(1);

- v8::Local<v8::ObjectTemplate> instanceTemplate = functionTemplate->InstanceTemplate();

- v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();

- UNUSED_PARAM(instanceTemplate);

- UNUSED_PARAM(prototypeTemplate);

+ v8::Local<v8::ObjectTemplate> ALLOW_UNUSED instanceTemplate = functionTemplate->InstanceTemplate();

+ v8::Local<v8::ObjectTemplate> ALLOW_UNUSED prototypeTemplate = functionTemplate->PrototypeTemplate();

// Custom toString template

functionTemplate->Set(v8::String::NewFromUtf8(isolate, "toString", v8::String::kInternalizedString), V8PerIsolateData::current()->toStringTemplate());