Source/bindings/tests/results/V8TestInterface.cpp - Issue 34273002: Remove UnusedParam.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterface.cpp

Issue 34273002: Remove UnusedParam.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove unused variables from signatures Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestExtendedEvent.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp » ('j') | Source/platform/graphics/GraphicsContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterface.cpp

diff --git a/Source/bindings/tests/results/V8TestInterface.cpp b/Source/bindings/tests/results/V8TestInterface.cpp

index 4c5266cd9900a2204d51d061c091b1214334b15a..58d3fc2faf510c843ce27dde81bd281d1599c51e 100644

--- a/Source/bindings/tests/results/V8TestInterface.cpp

+++ b/Source/bindings/tests/results/V8TestInterface.cpp

@@ -54,7 +54,6 @@

#include "platform/TraceEvent.h"

#include "wtf/GetPtr.h"

#include "wtf/RefPtr.h"

-#include "wtf/UnusedParam.h"

namespace WebCore {

@@ -840,19 +839,16 @@ static v8::Handle<v8::FunctionTemplate> ConfigureV8TestInterfaceTemplate(v8::Han

{

functionTemplate->ReadOnlyPrototype();

- v8::Local<v8::Signature> defaultSignature;

+ v8::Local<v8::Signature> ALLOW_UNUSED defaultSignature;

defaultSignature = V8DOMConfiguration::installDOMClassTemplate(functionTemplate, "TestInterface", v8::Local<v8::FunctionTemplate>(), V8TestInterface::internalFieldCount,

V8TestInterfaceAttributes, WTF_ARRAY_LENGTH(V8TestInterfaceAttributes),

0, 0,

V8TestInterfaceMethods, WTF_ARRAY_LENGTH(V8TestInterfaceMethods),

isolate, currentWorldType);

- UNUSED_PARAM(defaultSignature);

functionTemplate->SetCallHandler(V8TestInterface::constructorCallback);

functionTemplate->SetLength(1);

- v8::Local<v8::ObjectTemplate> instanceTemplate = functionTemplate->InstanceTemplate();

- v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();

- UNUSED_PARAM(instanceTemplate);

- UNUSED_PARAM(prototypeTemplate);

+ v8::Local<v8::ObjectTemplate> ALLOW_UNUSED instanceTemplate = functionTemplate->InstanceTemplate();

+ v8::Local<v8::ObjectTemplate> ALLOW_UNUSED prototypeTemplate = functionTemplate->PrototypeTemplate();

if (RuntimeEnabledFeatures::featureName23Enabled()) {

static const V8DOMConfiguration::AttributeConfiguration attributeConfiguration =\

{"Node23", TestInterfaceV8Internal::Node23AttributeGetterCallback, TestInterfaceV8Internal::Node23AttributeSetterCallback, 0, 0, 0, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */};