Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: Source/web/WebPagePopupImpl.cpp

Issue 34273002: Remove UnusedParam.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/WebKit.cpp ('k') | Source/web/WebSettingsImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 virtual void setWindowRect(const FloatRect& rect) OVERRIDE 80 virtual void setWindowRect(const FloatRect& rect) OVERRIDE
81 { 81 {
82 m_popup->m_windowRectInScreen = IntRect(rect); 82 m_popup->m_windowRectInScreen = IntRect(rect);
83 m_popup->widgetClient()->setWindowRect(m_popup->m_windowRectInScreen); 83 m_popup->widgetClient()->setWindowRect(m_popup->m_windowRectInScreen);
84 } 84 }
85 85
86 virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String&, const String&) OVERRIDE 86 virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String&, const String&) OVERRIDE
87 { 87 {
88 #ifndef NDEBUG 88 #ifndef NDEBUG
89 fprintf(stderr, "CONSOLE MESSSAGE:%u: %s\n", lineNumber, message.utf8(). data()); 89 fprintf(stderr, "CONSOLE MESSSAGE:%u: %s\n", lineNumber, message.utf8(). data());
90 #else
91 UNUSED_PARAM(message);
92 UNUSED_PARAM(lineNumber);
93 #endif 90 #endif
94 } 91 }
95 92
96 virtual void invalidateContentsAndRootView(const IntRect& paintRect) OVERRID E 93 virtual void invalidateContentsAndRootView(const IntRect& paintRect) OVERRID E
97 { 94 {
98 if (paintRect.isEmpty()) 95 if (paintRect.isEmpty())
99 return; 96 return;
100 m_popup->widgetClient()->didInvalidateRect(paintRect); 97 m_popup->widgetClient()->didInvalidateRect(paintRect);
101 } 98 }
102 99
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 // A WebPagePopupImpl instance usually has two references. 337 // A WebPagePopupImpl instance usually has two references.
341 // - One owned by the instance itself. It represents the visible widget. 338 // - One owned by the instance itself. It represents the visible widget.
342 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 339 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
343 // WebPagePopupImpl to close. 340 // WebPagePopupImpl to close.
344 // We need them because the closing operation is asynchronous and the widget 341 // We need them because the closing operation is asynchronous and the widget
345 // can be closed while the WebViewImpl is unaware of it. 342 // can be closed while the WebViewImpl is unaware of it.
346 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 343 return adoptRef(new WebPagePopupImpl(client)).leakRef();
347 } 344 }
348 345
349 } // namespace blink 346 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/WebKit.cpp ('k') | Source/web/WebSettingsImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698