Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 34273002: Remove UnusedParam.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove unnecessary ALLOW_UNUSED from the binding generator Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 4484 matching lines...) Expand 10 before | Expand all | Expand 10 after
4495 defaultSignature = V8DOMConfiguration::installDOMClassTemplate(functionT emplate, \"\", $parentClassTemplate, ${v8ClassName}::internalFieldCount, 0, 0, 0 , 0, 0, 0, isolate, currentWorldType); 4495 defaultSignature = V8DOMConfiguration::installDOMClassTemplate(functionT emplate, \"\", $parentClassTemplate, ${v8ClassName}::internalFieldCount, 0, 0, 0 , 0, 0, 0, isolate, currentWorldType);
4496 else 4496 else
4497 END 4497 END
4498 } 4498 }
4499 $code .= $runtimeEnabledIndent . " defaultSignature = V8DOMConfiguration: :installDOMClassTemplate(functionTemplate, \"${interfaceName}\", $parentClassTem plate, ${v8ClassName}::internalFieldCount,\n"; 4499 $code .= $runtimeEnabledIndent . " defaultSignature = V8DOMConfiguration: :installDOMClassTemplate(functionTemplate, \"${interfaceName}\", $parentClassTem plate, ${v8ClassName}::internalFieldCount,\n";
4500 $code .= $runtimeEnabledIndent . " " . ($hasAttributes ? "${v8ClassNa me}Attributes, WTF_ARRAY_LENGTH(${v8ClassName}Attributes),\n" : "0, 0,\n"); 4500 $code .= $runtimeEnabledIndent . " " . ($hasAttributes ? "${v8ClassNa me}Attributes, WTF_ARRAY_LENGTH(${v8ClassName}Attributes),\n" : "0, 0,\n");
4501 $code .= $runtimeEnabledIndent . " " . ($hasAccessors ? "${v8ClassNam e}Accessors, WTF_ARRAY_LENGTH(${v8ClassName}Accessors),\n" : "0, 0,\n"); 4501 $code .= $runtimeEnabledIndent . " " . ($hasAccessors ? "${v8ClassNam e}Accessors, WTF_ARRAY_LENGTH(${v8ClassName}Accessors),\n" : "0, 0,\n");
4502 $code .= $runtimeEnabledIndent . " " . ($hasFunctions ? "${v8ClassNam e}Methods, WTF_ARRAY_LENGTH(${v8ClassName}Methods),\n" : "0, 0,\n"); 4502 $code .= $runtimeEnabledIndent . " " . ($hasFunctions ? "${v8ClassNam e}Methods, WTF_ARRAY_LENGTH(${v8ClassName}Methods),\n" : "0, 0,\n");
4503 $code .= $runtimeEnabledIndent . " isolate, currentWorldType);\n"; 4503 $code .= $runtimeEnabledIndent . " isolate, currentWorldType);\n";
4504 4504
4505 AddToImplIncludes("wtf/UnusedParam.h");
4506 $code .= " UNUSED_PARAM(defaultSignature);\n";
4507
4508 if (IsConstructable($interface)) { 4505 if (IsConstructable($interface)) {
4509 $code .= " functionTemplate->SetCallHandler(${v8ClassName}::construct orCallback);\n"; 4506 $code .= " functionTemplate->SetCallHandler(${v8ClassName}::construct orCallback);\n";
4510 my $interfaceLength = GetInterfaceLength($interface); 4507 my $interfaceLength = GetInterfaceLength($interface);
4511 $code .= " functionTemplate->SetLength(${interfaceLength});\n"; 4508 $code .= " functionTemplate->SetLength(${interfaceLength});\n";
4512 } 4509 }
4513 4510
4514 $code .= <<END; 4511 $code .= <<END;
4515 v8::Local<v8::ObjectTemplate> instanceTemplate = functionTemplate->InstanceT emplate(); 4512 v8::Local<v8::ObjectTemplate> ALLOW_UNUSED instanceTemplate = functionTempla te->InstanceTemplate();
4516 v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->Prototyp eTemplate(); 4513 v8::Local<v8::ObjectTemplate> ALLOW_UNUSED prototypeTemplate = functionTempl ate->PrototypeTemplate();
4517 UNUSED_PARAM(instanceTemplate);
4518 UNUSED_PARAM(prototypeTemplate);
4519 END 4514 END
4520 4515
4521 if ($accessCheck) { 4516 if ($accessCheck) {
4522 $code .= " $accessCheck\n"; 4517 $code .= " $accessCheck\n";
4523 } 4518 }
4524 4519
4525 # Define runtime enabled attributes. 4520 # Define runtime enabled attributes.
4526 foreach my $runtimeEnabledAttribute (@runtimeEnabledAttributes) { 4521 foreach my $runtimeEnabledAttribute (@runtimeEnabledAttributes) {
4527 my $runtimeEnabledFunction = GetRuntimeEnabledFunctionName($runtimeEnabl edAttribute); 4522 my $runtimeEnabledFunction = GetRuntimeEnabledFunctionName($runtimeEnabl edAttribute);
4528 my $conditionalString = GenerateConditionalString($runtimeEnabledAttribu te); 4523 my $conditionalString = GenerateConditionalString($runtimeEnabledAttribu te);
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
4687 4682
4688 END 4683 END
4689 $implementation{nameSpaceWebCore}->add($code); 4684 $implementation{nameSpaceWebCore}->add($code);
4690 } 4685 }
4691 4686
4692 if (@perContextEnabledFunctions) { 4687 if (@perContextEnabledFunctions) {
4693 my $code = ""; 4688 my $code = "";
4694 $code .= <<END; 4689 $code .= <<END;
4695 void ${v8ClassName}::installPerContextEnabledMethods(v8::Handle<v8::Object> prot otypeTemplate, v8::Isolate* isolate) 4690 void ${v8ClassName}::installPerContextEnabledMethods(v8::Handle<v8::Object> prot otypeTemplate, v8::Isolate* isolate)
4696 { 4691 {
4697 UNUSED_PARAM(prototypeTemplate);
4698 END 4692 END
4699 # Define per-context enabled operations. 4693 # Define per-context enabled operations.
4700 $code .= <<END; 4694 $code .= <<END;
4701 v8::Local<v8::Signature> defaultSignature = v8::Signature::New(isolate, GetT emplate(isolate, worldType(isolate))); 4695 v8::Local<v8::Signature> defaultSignature = v8::Signature::New(isolate, GetT emplate(isolate, worldType(isolate)));
4702 UNUSED_PARAM(defaultSignature);
4703 4696
4704 ExecutionContext* context = toExecutionContext(prototypeTemplate->CreationCo ntext()); 4697 ExecutionContext* context = toExecutionContext(prototypeTemplate->CreationCo ntext());
4705 END 4698 END
4706 4699
4707 foreach my $perContextEnabledFunction (@perContextEnabledFunctions) { 4700 foreach my $perContextEnabledFunction (@perContextEnabledFunctions) {
4708 my $contextEnabledFunction = GetContextEnabledFunctionName($perConte xtEnabledFunction); 4701 my $contextEnabledFunction = GetContextEnabledFunctionName($perConte xtEnabledFunction);
4709 my $functionLength = GetFunctionLength($perContextEnabledFunction); 4702 my $functionLength = GetFunctionLength($perContextEnabledFunction);
4710 my $conditionalString = GenerateConditionalString($perContextEnabled Function); 4703 my $conditionalString = GenerateConditionalString($perContextEnabled Function);
4711 $code .= "\n#if ${conditionalString}\n" if $conditionalString; 4704 $code .= "\n#if ${conditionalString}\n" if $conditionalString;
4712 $code .= " if (context && context->isDocument() && ${contextEnabl edFunction}(toDocument(context)))\n"; 4705 $code .= " if (context && context->isDocument() && ${contextEnabl edFunction}(toDocument(context)))\n";
(...skipping 1666 matching lines...) Expand 10 before | Expand all | Expand 10 after
6379 6372
6380 return 1 if $interface->extendedAttributes->{"CustomToV8"}; 6373 return 1 if $interface->extendedAttributes->{"CustomToV8"};
6381 return 1 if $interface->extendedAttributes->{"CustomWrap"}; 6374 return 1 if $interface->extendedAttributes->{"CustomWrap"};
6382 return 1 if $interface->extendedAttributes->{"SpecialWrapFor"}; 6375 return 1 if $interface->extendedAttributes->{"SpecialWrapFor"};
6383 return 1 if InheritsInterface($interface, "Document"); 6376 return 1 if InheritsInterface($interface, "Document");
6384 6377
6385 return 0; 6378 return 0;
6386 } 6379 }
6387 6380
6388 1; 6381 1;
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/v8_interface.py » ('j') | Source/bindings/templates/interface.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698