Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: chrome/browser/about_flags.cc

Issue 342713007: [AiS] Add disable flag to about_flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 89f854c814c050ad8f6204a70298c6bf2d708979..7a09fef2b78c7c8d26848affafc86508c1daed9b 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -408,6 +408,16 @@ const Experiment::Choice kExtensionContentVerificationChoices[] = {
extensions::switches::kExtensionContentVerificationEnforceStrict },
};
+#if defined(OS_ANDROID)
+const Experiment::Choice kAnswersInSuggestChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
+ switches::kEnableAnswersInSuggest, ""},
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
+ switches::kDisableAnswersInSuggest, ""}
+};
+#endif
+
// Using independent flags (instead of flag=value flags) to be able to
// associate the version with a FieldTrial. FieldTrials don't currently support
// flag=value flags.
@@ -1908,11 +1918,11 @@ const Experiment kExperiments[] = {
},
#if defined(OS_ANDROID)
{
- "enable-answers-in-suggest",
+ "answers-in-suggest",
IDS_FLAGS_ENABLE_ANSWERS_IN_SUGGEST_NAME,
IDS_FLAGS_ENABLE_ANSWERS_IN_SUGGEST_DESCRIPTION,
kOsAndroid,
- SINGLE_VALUE_TYPE(switches::kEnableAnswersInSuggest)
+ MULTI_VALUE_TYPE(kAnswersInSuggestChoices)
},
#endif
{
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698