Issue 342693003: Removing using declarations that import names in the C++ Standard library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342693003: Removing using declarations that import names in the C++ Standard library. (Closed)

Created:
6 years, 6 months ago by harpreet.sk

Modified:
6 years, 6 months ago

Reviewers:
eseidel

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Removing using declarations that import names in the C++ Standard library. According to the coding guidelines for blink, we should not use "using" declarations of any kind to import names in the C++ Standard library. This patch removes all those "using" declarations. Effected folder: Source/core/css Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176436

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -33 lines)			Patch
M	Source/core/css/CSSFontSelector.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSGradientValue.cpp	View	5 chunks	+10 lines, -12 lines	0 comments	Download
M	Source/core/css/CSSReflectValue.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/PropertySetCSSStyleDeclaration.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/StylePropertySerializer.cpp	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	Source/core/css/StylePropertySet.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/parser/BisonCSSParser-in.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	4 chunks	+3 lines, -5 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/342693003/1

6 years, 6 months ago (2014-06-18 15:30:07 UTC) #3

Message was sent while issue was closed.

Change committed as 176436

Expand Messages | Collapse Messages