Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 342683008: [DevTools] Fix UI extreme cases: very small window and very large zoom. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Fix UI extreme cases: very small window and very large zoom. BUG=388185 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M Source/devtools/front_end/components/InspectedPagePlaceholder.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/InspectorView.js View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/inspector.css View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/SplitView.js View 6 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dgozman
Take a look please.
6 years, 6 months ago (2014-06-24 15:08:50 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-24 15:10:17 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-06-26 16:58:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/342683008/1
6 years, 5 months ago (2014-06-26 16:59:26 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-26 18:03:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-26 18:08:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/1832)
6 years, 5 months ago (2014-06-26 18:08:56 UTC) #7
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-06-27 06:58:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/342683008/1
6 years, 5 months ago (2014-06-27 06:58:46 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 07:09:02 UTC) #10
Message was sent while issue was closed. 
Change committed as 177076

Powered by Google App Engine
This is Rietveld 408576698