Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 342633003: [Android] Select text when stylus first button is pressed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 120161d67e823db56a39e5bace562b2155e70849..f25fb8a2b6dd0330d2d6f32f76f733f0d22753d0 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -542,6 +542,12 @@ void RenderWidgetHostViewAndroid::OnSmartClipDataExtracted(
content_view_core_->OnSmartClipDataExtracted(result);
}
+bool RenderWidgetHostViewAndroid::ShouldConvertToMouseEvent(
+ const ui::MotionEvent& event) {
+ // TODO(changwan)
+ return true;
+}
+
bool RenderWidgetHostViewAndroid::OnTouchEvent(
const ui::MotionEvent& event) {
if (!host_)
@@ -550,6 +556,11 @@ bool RenderWidgetHostViewAndroid::OnTouchEvent(
if (!gesture_provider_.OnTouchEvent(event))
return false;
+ if (ShouldConvertToMouseEvent(event)) {
jdduke (slow) 2014/06/19 15:10:11 Ah, yeah, so we would definitely need to move this
jdduke (slow) 2014/06/20 02:14:27 We'll probably want logic along the lines of: if
jdduke (slow) 2014/06/20 02:23:39 Actually this should probably be: if (event.GetAc
Changwan Ryu 2014/06/20 08:19:53 Done.
Changwan Ryu 2014/06/20 08:19:53 Done.
Changwan Ryu 2014/06/20 08:19:53 Moved it up and added a TODO.
+ SendMouseEvent(CreateWebMouseEventFromMotionEvent(event));
+ return true;
+ }
+
// Short-circuit touch forwarding if no touch handlers exist.
if (!host_->ShouldForwardTouchEvent()) {
const bool event_consumed = false;

Powered by Google App Engine
This is Rietveld 408576698