[Android] Select text when stylus first button is pressed.

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include "base/android/sys_utils.h"
 #include "base/basictypes.h"
@@ skipping 176 matching lines @@
           switches::kDisableOverscrollEdgeEffect)),
       overscroll_effect_(OverscrollGlow::Create(overscroll_effect_enabled_)),
       gesture_provider_(CreateGestureProviderConfig(), this),
       flush_input_requested_(false),
       accelerated_surface_route_id_(0),
       using_synchronous_compositor_(SynchronousCompositorImpl::FromID(
                                         widget_host->GetProcess()->GetID(),
                                         widget_host->GetRoutingID()) != NULL),
       frame_evictor_(new DelegatedFrameEvictor(this)),
       locks_on_frame_count_(0),
-      observing_root_window_(false) {
+      observing_root_window_(false),
+      convert_touch_sequence_to_mouse_(false) {
   host_->SetView(this);
   SetContentViewCore(content_view_core);
   ImageTransportFactoryAndroid::AddObserver(this);
 }
 
 RenderWidgetHostViewAndroid::~RenderWidgetHostViewAndroid() {
   ImageTransportFactoryAndroid::RemoveObserver(this);
   SetContentViewCore(NULL);
   DCHECK(ack_callbacks_.empty());
   if (resource_collection_.get())
@@ skipping 332 matching lines @@
   CHECK(RenderProcessHost::run_renderer_in_process());
   if (content_view_core_)
     content_view_core_->OnSmartClipDataExtracted(result);
 }
 
 bool RenderWidgetHostViewAndroid::OnTouchEvent(
     const ui::MotionEvent& event) {
   if (!host_)
     return false;
 
+  if (event.GetAction() == ui::MotionEvent::ACTION_DOWN) {
+    convert_touch_sequence_to_mouse_ =

[jdduke (slow), 2014/06/20 16:52:49]

Sorry, my previous comment was confusing.

You'll want to move this added block of code down below "if
(!gesture_provider_.OnTouchEvent(event))", which will allow us to use the same
gesture detector for all the events.

[Changwan Ryu, 2014/06/23 06:39:22]

Done.

+        ContentViewCoreImpl::ShouldConvertToMouseEvent(event);
+    // TODO(changwan): add a gesture detector to handle the long press event.

[jdduke (slow), 2014/06/20 16:52:49]

If you move this block below as in the previous comment, you won't need the
extra detector here.

[Changwan Ryu, 2014/06/23 06:39:22]

Done.

+  }
+
+  if (convert_touch_sequence_to_mouse_) {
+    SendMouseEvent(CreateWebMouseEventFromMotionEvent(event));
+    gesture_provider_.OnTouchEventAck(false);
+    if (event.GetAction() == ui::MotionEvent::ACTION_UP ||

[jdduke (slow), 2014/06/20 16:52:49]

I lied, we actually don't want this line to reset
|convert_touch_sequence_to_mouse_|, as then we might get a delayed GESTURE_TAP
event after the timeout.  It should be sufficient to reset the bit only with
ACTION_DOWN.

[Changwan Ryu, 2014/06/23 06:39:22]

Done.

+        event.GetAction() == ui::MotionEvent::ACTION_CANCEL)
+      convert_touch_sequence_to_mouse_ = false;
+    return true;
+  }
+
   if (!gesture_provider_.OnTouchEvent(event))
     return false;
 
   // Short-circuit touch forwarding if no touch handlers exist.
   if (!host_->ShouldForwardTouchEvent()) {
     const bool event_consumed = false;
     gesture_provider_.OnTouchEventAck(event_consumed);
     return true;
   }
 
@@ skipping 712 matching lines @@
 
 void RenderWidgetHostViewAndroid::RunAckCallbacks() {
   while (!ack_callbacks_.empty()) {
     ack_callbacks_.front().Run();
     ack_callbacks_.pop();
   }
 }
 
 void RenderWidgetHostViewAndroid::OnGestureEvent(
     const ui::GestureEventData& gesture) {
   SendGestureEvent(CreateWebGestureEventFromGestureEventData(gesture));

[jdduke (slow), 2014/06/20 16:52:49]

By using the same gesture detector, we can filter out undesired gestures here
depending on the |convert_touch_sequence_to_mouse_| flag.

[jdduke (slow), 2014/06/20 21:57:58]

Let's chat about this early next week.  I'm thinking that, instead of sending
WebMouseEvents (per Rick's email and offline discussion with Grace), we suppress
all gestures here (while |convert_touch_sequence_to_mouse_| is true, probably
need to rename that field), except for TAP/LONG_PRESS (it's not clear to me
which gesture they want to select a word), and then we use the
SCROLL_BEGIN/UPDATE/END gestures to dictate the |selectBetweenCoordinates|
commands. 

[Changwan Ryu, 2014/06/23 06:39:22]

I have uploaded a version that filters out gestures when
gesture_text_selection_triggered_ is false, except for LONG PRESS event. This
kind of works. :)

 }
 
 void RenderWidgetHostViewAndroid::OnCompositingDidCommit() {
   RunAckCallbacks();
 }
 
 void RenderWidgetHostViewAndroid::OnDetachCompositor() {
   DCHECK(content_view_core_);
   DCHECK(!using_synchronous_compositor_);
   RunAckCallbacks();
@@ skipping 143 matching lines @@
   results->availableRect = display.work_area();
   results->deviceScaleFactor = display.device_scale_factor();
   results->orientationAngle = display.RotationAsDegree();
   gfx::DeviceDisplayInfo info;
   results->depth = info.GetBitsPerPixel();
   results->depthPerComponent = info.GetBitsPerComponent();
   results->isMonochrome = (results->depthPerComponent == 0);
 }
 
 } // namespace content