Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 342573002: Add chrome.virtualKeyboardPrivate.openSettings api to open settings page (Closed)

Created:
6 years, 6 months ago by bshe
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add chrome.virtualKeyboardPrivate.openSettings api to open settings page This will open chrome://settings/languages page after called. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M chrome/browser/extensions/api/input/input.h View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/virtual_keyboard_private.json View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bshe
Hey guys. Do you mind to take a look at this CL? Virtual keyboard needs ...
6 years, 6 months ago (2014-06-17 22:00:09 UTC) #1
Ilya Sherman
histograms lgtm
6 years, 6 months ago (2014-06-17 22:07:26 UTC) #2
kevers
lgtm
6 years, 6 months ago (2014-06-18 11:51:57 UTC) #3
bshe
On 2014/06/18 11:51:57, kevers wrote: > lgtm mek@ friendly ping? Sorry for my impatience. But ...
6 years, 6 months ago (2014-06-18 21:37:51 UTC) #4
Marijn Kruisselbrink
On 2014/06/18 21:37:51, bshe wrote: > On 2014/06/18 11:51:57, kevers wrote: > > lgtm > ...
6 years, 6 months ago (2014-06-18 23:01:15 UTC) #5
bshe
The CQ bit was checked by bshe@chromium.org
6 years, 6 months ago (2014-06-19 11:07:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/342573002/1
6 years, 6 months ago (2014-06-19 11:09:09 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 18:54:11 UTC) #8
Message was sent while issue was closed.
Change committed as 278439

Powered by Google App Engine
This is Rietveld 408576698