Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: sdk/lib/_internal/pub/test/package_list_files_test.dart

Issue 342553002: Respect git's ignore rules pervasively in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review, performance improvements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/package_list_files_test.dart
diff --git a/sdk/lib/_internal/pub/test/package_files_test.dart b/sdk/lib/_internal/pub/test/package_list_files_test.dart
similarity index 91%
rename from sdk/lib/_internal/pub/test/package_files_test.dart
rename to sdk/lib/_internal/pub/test/package_list_files_test.dart
index d7eb5d2bd5561833cd7bd5ae057fae19c04abd79..9b5a06c315dd7a990322d2a3ce2723232ae041ed 100644
--- a/sdk/lib/_internal/pub/test/package_files_test.dart
+++ b/sdk/lib/_internal/pub/test/package_list_files_test.dart
@@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library packages_files_test;
+library packages_list_files_test;
import 'package:path/path.dart' as path;
import 'package:scheduled_test/scheduled_test.dart';
@@ -37,7 +37,7 @@ main() {
]).create();
schedule(() {
- expect(entrypoint.packageFiles(), unorderedEquals([
+ expect(entrypoint.root.listFiles(), unorderedEquals([
path.join(root, 'pubspec.yaml'),
path.join(root, 'file1.txt'),
path.join(root, 'file2.txt'),
@@ -68,7 +68,7 @@ main() {
]).create();
schedule(() {
- expect(entrypoint.packageFiles(), unorderedEquals([
+ expect(entrypoint.root.listFiles(), unorderedEquals([
path.join(root, 'pubspec.yaml'),
path.join(root, 'file1.txt'),
path.join(root, 'file2.txt'),
@@ -90,7 +90,7 @@ main() {
]).create();
schedule(() {
- expect(entrypoint.packageFiles(), unorderedEquals([
+ expect(entrypoint.root.listFiles(), unorderedEquals([
path.join(root, 'pubspec.yaml'),
path.join(root, '.gitignore'),
path.join(root, 'file2.text'),
@@ -122,7 +122,7 @@ void commonTests() {
schedule(() => deleteEntry(path.join(sandboxDir, appPath, 'target')));
schedule(() {
- expect(entrypoint.packageFiles(),
+ expect(entrypoint.root.listFiles(),
equals([path.join(root, 'pubspec.yaml')]));
});
});
@@ -134,7 +134,7 @@ void commonTests() {
]).create();
schedule(() {
- expect(entrypoint.packageFiles(),
+ expect(entrypoint.root.listFiles(),
equals([path.join(root, 'pubspec.yaml')]));
});
});
@@ -148,7 +148,7 @@ void commonTests() {
]).create();
schedule(() {
- expect(entrypoint.packageFiles(),
+ expect(entrypoint.root.listFiles(),
equals([path.join(root, 'pubspec.yaml')]));
});
});
@@ -161,7 +161,7 @@ void commonTests() {
]).create();
schedule(() {
- expect(entrypoint.packageFiles(), unorderedEquals([
+ expect(entrypoint.root.listFiles(), unorderedEquals([
path.join(root, 'pubspec.yaml'),
path.join(root, 'pubspec.lock', 'file.txt')
]));
@@ -184,7 +184,7 @@ void commonTests() {
]).create();
schedule(() {
- expect(entrypoint.packageFiles(beneath: path.join(root, 'subdir')),
+ expect(entrypoint.root.listFiles(beneath: path.join(root, 'subdir')),
unorderedEquals([
path.join(root, 'subdir', 'subfile1.txt'),
path.join(root, 'subdir', 'subfile2.txt'),
@@ -209,7 +209,7 @@ void commonTests() {
]).create();
schedule(() {
- expect(entrypoint.packageFiles(beneath: path.join(root, 'packages')),
+ expect(entrypoint.root.listFiles(beneath: path.join(root, 'packages')),
unorderedEquals([
path.join(root, 'packages', 'subfile1.txt'),
path.join(root, 'packages', 'subfile2.txt'),

Powered by Google App Engine
This is Rietveld 408576698