Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 342543003: Increased timeout for rietveld lint calls. (Closed)

Created:
6 years, 6 months ago by jrobbins
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Dirk Pranke, macourteau, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Increased timeout for rietveld lint calls. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=279463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M gcl.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/gcl_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Jason Robbins -- corp
This should resolve the timeout and repeated retry problem that macourteau emailed about today.
6 years, 6 months ago (2014-06-17 20:44:47 UTC) #1
smut
lgtm
6 years, 6 months ago (2014-06-17 20:58:18 UTC) #2
Jason Robbins -- corp
The CQ bit was checked by jrobbins@google.com
6 years, 6 months ago (2014-06-17 21:59:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrobbins@chromium.org/342543003/1
6 years, 6 months ago (2014-06-17 21:59:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 21:59:35 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-17 21:59:36 UTC) #6
Jason Robbins -- corp
smut, maybe you need to lgtm with your @chromium.org account. I'm also adding iannucci because ...
6 years, 6 months ago (2014-06-17 22:03:05 UTC) #7
smut
On 2014/06/17 22:03:05, Jason Robbins (corp) wrote: > smut, maybe you need to lgtm with ...
6 years, 6 months ago (2014-06-17 22:30:41 UTC) #8
Jason Robbins -- corp
ping. iannucci, can you approve this, if it looks right?
6 years, 6 months ago (2014-06-19 16:52:11 UTC) #9
iannucci
lgtm
6 years, 5 months ago (2014-06-24 19:01:07 UTC) #10
Jason Robbins -- corp
The CQ bit was checked by jrobbins@google.com
6 years, 5 months ago (2014-06-24 19:27:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrobbins@chromium.org/342543003/1
6 years, 5 months ago (2014-06-24 19:28:51 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-06-24 19:30:44 UTC) #13
Message was sent while issue was closed.
Change committed as 279463

Powered by Google App Engine
This is Rietveld 408576698