Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 342543002: Mojom interface for Surfaces service (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojom interface for Surfaces service Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278060

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -2 lines) Patch
M mojo/mojo_services.gypi View 1 chunk +17 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/geometry/geometry.mojom View 2 chunks +10 lines, -0 lines 0 comments Download
A mojo/services/public/interfaces/surfaces/quads.mojom View 1 chunk +165 lines, -0 lines 0 comments Download
A + mojo/services/public/interfaces/surfaces/surface_id.mojom View 1 chunk +6 lines, -2 lines 1 comment Download
A mojo/services/public/interfaces/surfaces/surfaces.mojom View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
It's partial but this is the interface I expect most clients of the surface system ...
6 years, 6 months ago (2014-06-17 20:13:11 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/342543002/diff/1/mojo/services/public/interfaces/surfaces/surface_id.mojom File mojo/services/public/interfaces/surfaces/surface_id.mojom (right): https://codereview.chromium.org/342543002/diff/1/mojo/services/public/interfaces/surfaces/surface_id.mojom#newcode8 mojo/services/public/interfaces/surfaces/surface_id.mojom:8: int32 id; why int32 vs uint32 btw?
6 years, 6 months ago (2014-06-17 21:32:32 UTC) #2
jamesr
On 2014/06/17 21:32:32, Ben Goodger (Google) wrote: > lgtm > > https://codereview.chromium.org/342543002/diff/1/mojo/services/public/interfaces/surfaces/surface_id.mojom > File mojo/services/public/interfaces/surfaces/surface_id.mojom ...
6 years, 6 months ago (2014-06-17 21:37:38 UTC) #3
Ben Goodger (Google)
On 2014/06/17 21:37:38, jamesr wrote: > On 2014/06/17 21:32:32, Ben Goodger (Google) wrote: > > ...
6 years, 6 months ago (2014-06-17 21:39:42 UTC) #4
piman
lgtm
6 years, 6 months ago (2014-06-17 23:12:44 UTC) #5
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-17 23:17:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/342543002/1
6 years, 6 months ago (2014-06-17 23:19:23 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 14:42:56 UTC) #8
Message was sent while issue was closed. 
Change committed as 278060

Powered by Google App Engine
This is Rietveld 408576698