Revert of Pick a fixed Clang revision for Windows now that we have an LKGR ASan builder

Revert of Pick a fixed Clang revision for Windows now that we have an LKGR ASan builder (https://codereview.chromium.org/320383004/)

Reason for revert:
This was landed despite an explicit "not lgtm"

Original issue's description:
> Pick a fixed Clang revision for Windows now that we have an LKGR ASan builder
> This way, the LKGR builder and the developers who want to try ASan (or just Clang) on Windows won't get a broken Clang revision.
> 
> The FYI bots got LLVM_WIN_REVISION=HEAD in r276301 so won't be affected.
> 
> BUG=82385, 345874
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276366

TBR=hans@chromium.org,rnk@chromium.org,timurrrr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385, 345874
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277837

[Nico, 2014-06-17 19:38:21]

Created Revert of Pick a fixed Clang revision for Windows now that we have an
LKGR ASan builder

[commit-bot: I haz the power, 2014-06-17 19:40:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/342533002/1

[commit-bot: I haz the power, 2014-06-17 19:42:54]

Change committed as 277837

[Timur Iskhodzhanov, 2014-06-17 23:46:54]

> This was landed despite an explicit "not lgtm"

Seems like the communication broke down somewhere in the middle?

The original change was committed after an approval from hans@  *more than 24h
before* you wrote "not lgtm":
2014-06-10 19:45 GMT+04:00  <hans@chromium.org>:
> I still worry [...] but if we make up [...] I think it's OK.
> lgtm

2014-06-11 16:24 GMT+04:00  <commit-bot@chromium.org>:
> Change committed as 276366

2014-06-12 23:42 GMT+04:00  <thakis@chromium.org>:
> as mentioned on the thread, not lgtm
––– this was the first time you've explicitly described your strong opinion
against this patch.
You didn't express a strong negative opinion on the internal thread either – and
I was under an impression that the approval Hans gave me was taking your opinion
into the account.

That being said, I completely don't understand what you've meant by using the
"despite" word.

[Timur Iskhodzhanov, 2014-06-17 23:48:00]

Abhishek,
After this change the ASan/Win LKGR builder may fail and/or make broken builds
at any time.
Please coordinate with rnk@ and thakis@ to fix that in a scalable way [I'm on
vacation till July 3]

[Timur Iskhodzhanov, 2014-06-17 23:48:56]

Also I don't see a reason for a full revert rather than just s/210586/HEAD/

[Nico, 2014-06-17 23:49:35]

"If you want a fixed clang revision number, I feel it should be identical
to the clang revision number the rest of chromium uses. I feel it's too
soon for that though." (from the internal thread)


On Tue, Jun 17, 2014 at 4:46 PM, <timurrrr@chromium.org> wrote:

> This was landed despite an explicit "not lgtm"
>>
>
> Seems like the communication broke down somewhere in the middle?
>
> The original change was committed after an approval from hans@  *more
> than 24h
> before* you wrote "not lgtm":
> 2014-06-10 19:45 GMT+04:00  <hans@chromium.org>:
>
>> I still worry [...] but if we make up [...] I think it's OK.
>> lgtm
>>
>
> 2014-06-11 16:24 GMT+04:00  <commit-bot@chromium.org>:
>
>> Change committed as 276366
>>
>
> 2014-06-12 23:42 GMT+04:00  <thakis@chromium.org>:
>
>> as mentioned on the thread, not lgtm
>>
> --- this was the first time you've explicitly described your strong opinion
> against this patch.
> You didn't express a strong negative opinion on the internal thread either
> - and
> I was under an impression that the approval Hans gave me was taking your
> opinion
> into the account.
>
> That being said, I completely don't understand what you've meant by using
> the
> "despite" word.
>
> https://codereview.chromium.org/342533002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Timur Iskhodzhanov, 2014-06-17 23:55:00]

This is not an explicit strong "not LGTM", right?
It's also not clear if "too soon though" weakens the "should be
identical" or refers to "fixed revision".

Again,
> I was under an impression that the approval Hans gave me was taking your
opinion
> into the account.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.