Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/heap_map.dart

Issue 342513004: Visual refresh of allocation profile page (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/heap_map.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/heap_map.dart b/runtime/bin/vmservice/client/lib/src/elements/heap_map.dart
index cba62c9702610dc929197c27ff629d5629ce0dfc..3674762da33d5bcf6a2909230e395b7d8e46c31d 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/heap_map.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/heap_map.dart
@@ -71,8 +71,9 @@ class HeapMapElement extends ObservatoryElement {
HeapMapElement.created() : super.created() {
}
- void enteredView() {
- super.enteredView();
+ @override
+ void attached() {
+ super.attached();
_fragmentationCanvas = shadowRoot.querySelector("#fragmentation");
_fragmentationCanvas.onMouseMove.listen(_handleMouseMove);
_fragmentationCanvas.onMouseDown.listen(_handleClick);
@@ -222,7 +223,7 @@ class HeapMapElement extends ObservatoryElement {
}
void fragmentationChanged(oldValue) {
- // Async, in case enteredView has not yet run (observed in JS version).
+ // Async, in case attached has not yet run (observed in JS version).
new Future(() {
_updateFragmentationData();
});

Powered by Google App Engine
This is Rietveld 408576698