Visual refresh of allocation profile page

runtime/bin/vmservice/client/lib/src/service/object.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of service;
 
 /// A [ServiceObject] is an object known to the VM service and is tied
 /// to an owning [Isolate].
 abstract class ServiceObject extends Observable {
   /// The owner of this [ServiceObject].  This can be an [Isolate], a
@@ skipping 172 matching lines @@
   @reflectable Iterable<Isolate> get isolates => _isolateCache.values;
 
   @reflectable String get link => '$id';
   @reflectable String relativeLink(String id) => '$id';
 
   @observable String version = 'unknown';
   @observable String architecture = 'unknown';
   @observable double uptime = 0.0;
   @observable bool assertsEnabled = false;
   @observable bool typeChecksEnabled = false;
+  @observable DateTime date;

[koda, 2014/06/17 21:04:07]

Please choose a more descriptive name. lastUpdated?

[Cutch, 2014/06/18 14:35:03]

Done.

 
   VM() : super._empty(null) {
     name = 'vm';
     vmName = 'vm';
     _cache['vm'] = this;
     update(toObservable({'id':'vm', 'type':'@VM'}));
   }
 
   final StreamController<ServiceException> exceptions =
       new StreamController.broadcast();
@@ skipping 163 matching lines @@
   Future<String> getString(String id);
 
   void _update(ObservableMap map, bool mapIsRef) {
     if (mapIsRef) {
       return;
     }
     _loaded = true;
     version = map['version'];
     architecture = map['architecture'];
     uptime = map['uptime'];
+    var dateInMillis = int.parse(map['date']);
+    date = new DateTime.fromMillisecondsSinceEpoch(dateInMillis);
     assertsEnabled = map['assertsEnabled'];
     typeChecksEnabled = map['typeChecksEnabled'];
     _updateIsolates(map['isolates']);
   }
 
   void _updateIsolates(List newIsolates) {
     var oldIsolateCache = _isolateCache;
     var newIsolateCache = new Map<String,Isolate>();
     for (var isolateMap in newIsolates) {
       var isolateId = isolateMap['id'];
@@ skipping 266 matching lines @@
   @observable ObservableMap topFrame;
 
   @observable String name;
   @observable String vmName;
   @observable String mainPort;
   @observable Map entry;
 
   @observable final Map<String, double> timers =
       toObservable(new Map<String, double>());
 
   @observable int newHeapUsed = 0;

[koda, 2014/06/17 21:04:06]

The same three fields are repeated for new and old. Consider creating an
abstraction.

[Cutch, 2014/06/18 14:35:03]

Done.

+  @observable int newHeapCapacity = 0;
+  @observable int newExternal = 0;
   @observable int oldHeapUsed = 0;
-  @observable int newHeapCapacity = 0;
   @observable int oldHeapCapacity = 0;
+  @observable int oldExternal = 0;
 
   @observable String fileAndLine;
 
   @observable DartError error;
 
+  void updateHeapsFromMap(ObservableMap map) {
+    newHeapUsed = map['new']['used'];
+    newHeapCapacity = map['new']['capacity'];
+    newExternal = map['new']['external'];
+    oldHeapUsed = map['old']['used'];
+    oldHeapCapacity = map['old']['capacity'];
+    oldExternal = map['old']['external'];
+  }
+
   void _update(ObservableMap map, bool mapIsRef) {
     mainPort = map['mainPort'];
     name = map['name'];
     vmName = map['name'];
     if (mapIsRef) {
       return;
     }
     _loaded = true;
     loading = false;
     _upgradeCollection(map, isolate);
     if (map['rootLib'] == null ||
         map['timers'] == null ||
-        map['heap'] == null) {
+        map['heaps'] == null) {
       Logger.root.severe("Malformed 'Isolate' response: $map");
       return;
     }
     rootLib = map['rootLib'];
     if (map['entry'] != null) {
       entry = map['entry'];
     }
     if (map['topFrame'] != null) {
       topFrame = map['topFrame'];
     } else {
@@ skipping 28 matching lines @@
       });
     timers['total'] = timerMap['time_total_runtime'];
     timers['compile'] = timerMap['time_compilation'];
     timers['gc'] = 0.0;  // TODO(turnidge): Export this from VM.
     timers['init'] = (timerMap['time_script_loading'] +
                       timerMap['time_creating_snapshot'] +
                       timerMap['time_isolate_initialization'] +
                       timerMap['time_bootstrap']);
     timers['dart'] = timerMap['time_dart_execution'];
 
-    newHeapUsed = map['heap']['usedNew'];
-    oldHeapUsed = map['heap']['usedOld'];
-    newHeapCapacity = map['heap']['capacityNew'];
-    oldHeapCapacity = map['heap']['capacityOld'];
+    updateHeapsFromMap(map['heaps']);
 
     List features = map['features'];
     if (features != null) {
       for (var feature in features) {
         if (feature == 'io') {
           ioEnabled = true;
         }
       }
     }
     // Isolate status
@@ skipping 219 matching lines @@
     scripts.addAll(map['scripts']);
     classes.clear();
     classes.addAll(map['classes']);
     variables.clear();
     variables.addAll(map['variables']);
     functions.clear();
     functions.addAll(map['functions']);
   }
 }
 
+class AllocationStat extends Observable {

[koda, 2014/06/17 21:04:06]

Consider adding pointer to the C++ counterpart in class_table.h.

[Cutch, 2014/06/18 14:35:03]

Done.

+  @observable int instances = 0;
+  @observable int bytes = 0;
+
+  void reset() {
+    instances = 0;
+    bytes = 0;
+  }
+
+  bool get empty => (instances == 0) && (bytes == 0);
+}
+
 class Class extends ServiceObject {
   @observable Library library;
   @observable Script script;
   @observable Class superClass;
 
   @observable bool isAbstract;
   @observable bool isConst;
   @observable bool isFinalized;
   @observable bool isPatch;
   @observable bool isImplemented;
 
   @observable int tokenPos;
 
   @observable ServiceMap error;
 
+  final AllocationStat accumulatedNewSpace = new AllocationStat();
+  final AllocationStat accumulatedOldSpace = new AllocationStat();
+  final AllocationStat currentNewSpace = new AllocationStat();
+  final AllocationStat currentOldSpace = new AllocationStat();
+
+  bool get hasNoAllocations {
+    return accumulatedNewSpace.empty &&
+           accumulatedOldSpace.empty &&
+           currentNewSpace.empty &&
+           currentOldSpace.empty;
+  }
+
   @reflectable final children = new ObservableList<Class>();
   @reflectable final subClasses = new ObservableList<Class>();
   @reflectable final fields = new ObservableList<ServiceMap>();
   @reflectable final functions = new ObservableList<ServiceMap>();
   @reflectable final interfaces = new ObservableList<Class>();
 
   bool get canCache => true;
   bool get immutable => false;
 
   Class._empty(ServiceObjectOwner owner) : super._empty(owner);
@@ skipping 738 matching lines @@
     var v = list[i];
     if ((v is ObservableMap) && _isServiceMap(v)) {
       list[i] = owner.getFromMap(v);
     } else if (v is ObservableList) {
       _upgradeObservableList(v, owner);
     } else if (v is ObservableMap) {
       _upgradeObservableMap(v, owner);
     }
   }
 }