Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart

Issue 342513004: Visual refresh of allocation profile page (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library isolate_view_element; 5 library isolate_view_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'observatory_element.dart'; 8 import 'observatory_element.dart';
9 import 'package:observatory/app.dart'; 9 import 'package:observatory/app.dart';
10 import 'package:observatory/service.dart'; 10 import 'package:observatory/service.dart';
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 isolate.updateTagProfile().then((tagProfile) { 92 isolate.updateTagProfile().then((tagProfile) {
93 tagProfileChart.update(tagProfile); 93 tagProfileChart.update(tagProfile);
94 _drawTagProfileChart(); 94 _drawTagProfileChart();
95 if (_updateTimer != null) { 95 if (_updateTimer != null) {
96 // Start the timer again. 96 // Start the timer again.
97 _updateTimer = new Timer(new Duration(seconds: 1), _updateTagProfile); 97 _updateTimer = new Timer(new Duration(seconds: 1), _updateTagProfile);
98 } 98 }
99 }); 99 });
100 } 100 }
101 101
102 void enteredView() { 102 @override
103 super.enteredView(); 103 void attached() {
104 super.attached();
104 // Start a timer to update the isolate summary once a second. 105 // Start a timer to update the isolate summary once a second.
105 _updateTimer = new Timer(new Duration(seconds: 1), _updateTagProfile); 106 _updateTimer = new Timer(new Duration(seconds: 1), _updateTagProfile);
106 } 107 }
107 108
108 void leftView() { 109 @override
109 super.leftView(); 110 void detached() {
111 super.detached();
110 if (_updateTimer != null) { 112 if (_updateTimer != null) {
111 _updateTimer.cancel(); 113 _updateTimer.cancel();
112 _updateTimer = null; 114 _updateTimer = null;
113 } 115 }
114 } 116 }
115 117
116 void _drawTagProfileChart() { 118 void _drawTagProfileChart() {
117 var element = shadowRoot.querySelector('#tagProfileChart'); 119 var element = shadowRoot.querySelector('#tagProfileChart');
118 if (element != null) { 120 if (element != null) {
119 tagProfileChart.draw(element); 121 tagProfileChart.draw(element);
(...skipping 15 matching lines...) Expand all
135 137
136 Future resume(_) { 138 Future resume(_) {
137 return isolate.get("resume").then((result) { 139 return isolate.get("resume").then((result) {
138 // TODO(turnidge): Instead of asserting here, handle errors 140 // TODO(turnidge): Instead of asserting here, handle errors
139 // properly. 141 // properly.
140 assert(result.serviceType == 'Success'); 142 assert(result.serviceType == 'Success');
141 return isolate.reload(); 143 return isolate.reload();
142 }); 144 });
143 } 145 }
144 } 146 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698