runtime/vm/heap.cc - Issue 342503002: Heap::AllocateExternal may trigger GC, so fix String::MakeExternal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/heap.cc

Issue 342503002: Heap::AllocateExternal may trigger GC, so fix String::MakeExternal. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/heap.cc

===================================================================

--- runtime/vm/heap.cc (revision 37393)

+++ runtime/vm/heap.cc (working copy)

@@ -92,6 +92,7 @@

}

void Heap::AllocateExternal(intptr_t size, Space space) {

+ ASSERT(isolate()->no_gc_scope_depth() == 0);

if (space == kNew) {

new_space_->AllocateExternal(size);

if (new_space_->ExternalInWords() > (FLAG_new_gen_ext_limit * MBInWords)) {

« no previous file with comments | « runtime/vm/dart_api_state.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »